Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turborepo #1296

Merged
merged 12 commits into from
May 30, 2022
Merged

Turborepo #1296

merged 12 commits into from
May 30, 2022

Conversation

emersonlaurentino
Copy link
Member

@emersonlaurentino emersonlaurentino commented May 13, 2022 •
edited
Loading

Since lerna died, this PR is intended to use turborepo.

For now, we're using turborepo + lerna; The first is responsible for task runner and the last is responsible for publishing.

We will gradually make some changes:

  • remove lerna completely to use another lib to publish (turborepo suggest Changesets)
  • repo to shared configs (tsconfig, prettier, eslint)
  • remote cache
  • rename @vtex/lighthouse-config to @faststore/lighthouse
  • rename @vtex/theme-b2c-tailwind to @faststore/theme (best name suggestions are welcome)
  • standardize script names (some are develop, others dev, others start)
  • use pnpm as package manager

Results on Build time:

Using lerna
Screen Shot 2022-05-13 at 15 02 53

Using turborepo
Screen Shot 2022-05-13 at 15 05 27

Using turborepo + cache
Screen Shot 2022-05-13 at 15 05 55

@emersonlaurentino emersonlaurentino self-assigned this May 13, 2022
@emersonlaurentino emersonlaurentino requested a review from a team as a code owner May 13, 2022 17:53
@vercel
Copy link

vercel bot commented May 13, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
faststore ✅ Ready (Inspect) Visit Preview May 30, 2022 at 5:46PM (UTC)

@emersonlaurentino emersonlaurentino force-pushed the turbo branch 2 times, most recently from 2c8a53d to c515b87 Compare May 13, 2022 18:20
igorbrasileiro
igorbrasileiro approved these changes May 13, 2022
View reviewed changes
lerna.json Show resolved Hide resolved
@codesandbox-ci
Copy link

codesandbox-ci bot commented May 30, 2022 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 19e3b42:

Sandbox Source
Store UI Typescript Configuration

@emersonlaurentino emersonlaurentino merged commit b1540be into main May 30, 2022
@emersonlaurentino emersonlaurentino deleted the turbo branch May 30, 2022 17:50
@eduardoformiga eduardoformiga mentioned this pull request Jul 21, 2022
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tlgimenes tlgimenes tlgimenes approved these changes

@igorbrasileiro igorbrasileiro igorbrasileiro approved these changes

Assignees

@emersonlaurentino emersonlaurentino

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emersonlaurentino @tlgimenes @igorbrasileiro