Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: shared tsconfig #1379

Merged
merged 11 commits into from
Jun 23, 2022
Merged

chore: shared tsconfig #1379

merged 11 commits into from
Jun 23, 2022

Conversation

emersonlaurentino
Copy link
Member

What's the purpose of this pull request?

remove @vtex/tsconfig and create a package shared that shares the tsconfig between all faststore packages/apps.

How it works?

looking at each package's tsconfig file and running the build script

How to test it?

yarn build

Starters Deploy Preview

References

@emersonlaurentino emersonlaurentino requested a review from a team as a code owner June 22, 2022 22:01
@emersonlaurentino emersonlaurentino self-assigned this Jun 22, 2022
@vercel
Copy link

vercel bot commented Jun 22, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
faststore ✅ Ready (Inspect) Visit Preview Jun 22, 2022 at 10:14PM (UTC)

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d809202:

Sandbox Source
Store UI Typescript Configuration

Copy link
Contributor

@filipewl filipewl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Nice clean-up.

@emersonlaurentino emersonlaurentino merged commit 973ad01 into main Jun 23, 2022
@emersonlaurentino emersonlaurentino deleted the feat/tscfg branch June 23, 2022 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants