Fix: Components styles and update data attributes #1287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
hellofanny
changed the title
hellofanny
commented
May 12, 2022
| @apply bg-transparent text-gray-800; | ||
| @apply hover:text-pink-600; | ||
| [data-accordion-button] { | ||
| color: #171a1c; |
There was a problem hiding this comment.
I do update this stylesheet. But this was not this task's purpose. So I decided to do it separately later.
mariana-caetano
approved these changes
May 12, 2022
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 29de70e:
|
mariana-caetano
added
the
documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this pull request?
I've noticed that some components' styles were broken in our documentation and found that we missed some updates after the changes made on this PR a while ago.
We changed multiple components' data attributes to enforce a new pattern, and we removed
storefrom the inner components/elements' data attributes. Still, we forgot to update them in some places.Note: The
Cardcomponent is also broken but addressed on another PRHow it works?
This PR should fix some styles and updates some docs.
AccordionBannerSliderTableHow to test it?
You can compare the components listed above in the current documentation and the preview.