-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Components styles and update data attributes #1287
Merged
Merged
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
29d3c22
Fixes `Accordion` components data-attributes
hellofanny f499601
Updates `Accordion` style
hellofanny e05fedc
Fixes `Banner` components data-attributes
hellofanny 0cbcfa8
Fixes `Slider` components data-attributes
hellofanny fe3f8dd
Updates `PriceRange` components data-attributes
hellofanny cecb71c
Updates `Table` components data-attributes
hellofanny 29de70e
Update Accordion.mdx
mariana-caetano File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,19 +1,38 @@ | ||
[data-store-accordion-button] { | ||
@apply bg-transparent text-gray-800; | ||
@apply hover:text-pink-600; | ||
[data-accordion-button] { | ||
color: #171a1c; | ||
background-color: transparent; | ||
} | ||
[data-store-icon] { | ||
@apply align-top ml-2; | ||
|
||
[data-accordion-button]:hover { | ||
color: #db2777; | ||
} | ||
[data-store-accordion-button][aria-expanded='true'] { | ||
@apply text-pink-600; | ||
|
||
[data-accordion-button] [data-store-icon] { | ||
margin-left: 0.5rem; | ||
vertical-align: middle; | ||
} | ||
[data-store-accordion-button][aria-expanded='true'] [data-store-icon] { | ||
@apply transform rotate-180; | ||
|
||
[data-accordion-button][aria-expanded='true'] { | ||
color: #db2777; | ||
} | ||
[data-store-accordion-panel] > ul { | ||
@apply list-none my-0 pl-10; | ||
|
||
[data-accordion-button][aria-expanded='true'] [data-store-icon] { | ||
transform: rotate(180deg); | ||
transition: transform .8s ease-in-out; | ||
} | ||
[data-store-accordion-panel] a { | ||
@apply text-gray-500 no-underline hover:text-blue-700; | ||
|
||
[data-accordion-panel] > ul { | ||
padding-left: 2.5rem; | ||
margin-top: 0px; | ||
margin-bottom: 0px; | ||
list-style-type: none; | ||
} | ||
|
||
[data-accordion-panel] a { | ||
text-decoration: none; | ||
color: #74808b; | ||
} | ||
|
||
[data-accordion-panel] a:hover { | ||
color: #00419e; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,45 +1,45 @@ | ||
[data-store-banner-image] { | ||
@apply w-full h-64; | ||
[data-store-banner='vertical'] { | ||
@apply flex flex-col; | ||
} | ||
|
||
[data-store-banner-image] img { | ||
@apply object-cover w-full h-full; | ||
[data-store-banner='vertical'] [data-banner-link] { | ||
@apply ml-auto; | ||
} | ||
|
||
[data-store-banner-content] { | ||
@apply flex p-7; | ||
[data-store-banner='horizontal'] { | ||
@apply grid grid-cols-2; | ||
} | ||
|
||
[data-store-banner-content] h3 { | ||
@apply font-medium text-xl; | ||
[data-store-banner='horizontal'] [data-banner-content] { | ||
@apply flex-col justify-between; | ||
} | ||
|
||
[data-store-banner='vertical'] { | ||
@apply flex flex-col; | ||
[data-store-banner='horizontal'] [data-banner-link] { | ||
@apply mr-auto; | ||
} | ||
|
||
[data-store-banner='vertical'] [data-store-banner-link] { | ||
@apply ml-auto; | ||
[data-banner-image] { | ||
@apply w-full h-64; | ||
} | ||
|
||
[data-store-banner='horizontal'] { | ||
@apply grid grid-cols-2; | ||
[data-banner-image] img { | ||
@apply object-cover w-full h-full; | ||
} | ||
|
||
[data-store-banner='horizontal'] [data-store-banner-content] { | ||
@apply flex-col justify-between; | ||
[data-banner-content] { | ||
@apply flex p-7; | ||
} | ||
|
||
[data-store-banner='horizontal'] [data-store-banner-link] { | ||
@apply mr-auto; | ||
[data-banner-content] h3 { | ||
@apply font-medium text-xl; | ||
} | ||
|
||
[data-store-banner-link] { | ||
[data-banner-link] { | ||
@apply px-6 py-2 rounded border-0 cursor-pointer inline-flex items-center; | ||
@apply bg-blue-800 text-white; | ||
@apply text-lg; | ||
} | ||
|
||
[data-store-banner-link] [data-store-icon] { | ||
[data-banner-link] [data-store-icon] { | ||
@apply m-auto ml-2 align-middle; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
[data-store-price-range-values] { | ||
[data-price-range-values] { | ||
@apply mt-4 flex justify-between; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do update this stylesheet. But this was not this task's purpose. So I decided to do it separately later.