Feat: Uses ProductCard component from FSUI
#34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Preview is readyThis pull request generated a Preview👀 Preview: https://preview-34--gatsby.preview.vtex.app |
Lighthouse ReportsHere are the Lighthouse reports of this Pull Request📝 Based on commit 791e82d
|
filipewl
approved these changes
May 16, 2022
hellofanny
force-pushed
the
feat/FSSS-2461-replace-product-card
branch
from
0102e4b to
37aed14
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this pull request?
This PR is part of the Component Placement project. Replaces
CardforProductCardHow does it work?
ProductCardcomponent from FSUI instead ofCardProductCardpropactionabledtoactionableHow to test it?
Nothing should change visually on the component.
Check on the preview if the
ProductCardis working fine as before.The
ProductCardcomponent appear on the Homepage and PLP:Checklist
You may erase this after checking them all ;)
ProductCardcomponent vtex/faststore#1272 is merged, update faststore/ui version on stores and merge those PRs as wellCHANGELOG.mdat the beginning of its due section. The latest version should comes first.CHANGELOG.md. E.g., New items in thepull_request_template.md(#12)