Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix problem that large images may disappear when printing with zero page margin #514

Merged
merged 2 commits into from
Apr 3, 2019
Merged

Fix problem that large images may disappear when printing with zero page margin #514

merged 2 commits into from
Apr 3, 2019

Conversation

MurakamiShinyu
Copy link
Member

This problem was a side effect of "Workaround for Chrome printing problem" (#394).
Changed to better workaround.

@MurakamiShinyu
Revert "Workaround for Chrome printing problem" (#394) causing large …
2837303 
…images to disappear

"Workaround for Chrome printing problem" #394 added `padding-top: 1px` on the bleed box, and causes side effects:
- The printable page content height becomes smaller
- Page breaking between the padding-top and the large image becomes possible, and because of `overflow:  hidden` the large image disappears

Another workaround needed.
@MurakamiShinyu
New workaround for Chrome printing problem
9e0016e 
This workaround (adding padding-top and negative margin-bottom on the before pseudo element of page-area/partition) is similar to the old workaround (adding padding-top on bleed-box ) but no problem of large images to disappear.

(The padding-top and negative margin-bottom value 0.015625px (1/64 px) is the minimum effective length on Chrome, I choose this value to minimize possible side effect.)
@MurakamiShinyu MurakamiShinyu merged commit 5ffe127 into master Apr 3, 2019
@MurakamiShinyu MurakamiShinyu deleted the chrome_print_bug branch April 4, 2019 09:50
@MurakamiShinyu MurakamiShinyu mentioned this pull request Jun 10, 2019
Closed
MurakamiShinyu added a commit that referenced this pull request Jan 4, 2023
@MurakamiShinyu
fix: remove workaround for old Chrome printing problem
b7e7084 
Remove the workaround code (#514 and #394) for Chrome printing problem which was already fixed and no longer necessary.

After this change the following problem that was a side effect of the old workaround code will be resolved:

- fix #660
MurakamiShinyu added a commit that referenced this pull request Jan 4, 2023
@MurakamiShinyu
fix: remove workaround for old Chrome printing problem
fbad411 
Remove the workaround code (#514 and #394) for Chrome printing problem which was already fixed and no longer necessary.

After this change the following problem that was a side effect of the old workaround code will be resolved:

- fix #600
@MurakamiShinyu MurakamiShinyu mentioned this pull request Jan 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@MurakamiShinyu