Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix problem that large images may disappear when printing with zero page margin #514

Merged
merged 2 commits into from
Apr 3, 2019
Merged

Fix problem that large images may disappear when printing with zero page margin #514

merged 2 commits into from
Apr 3, 2019

Commits on Apr 2, 2019

  1. Revert "Workaround for Chrome printing problem" (#394) causing large … 

    …images to disappear

"Workaround for Chrome printing problem" #394 added `padding-top: 1px` on the bleed box, and causes side effects:
- The printable page content height becomes smaller
- Page breaking between the padding-top and the large image becomes possible, and because of `overflow:  hidden` the large image disappears

Another workaround needed.
    @MurakamiShinyu
    MurakamiShinyu committed Apr 2, 2019
    Configuration menu
    Copy the full SHA
    2837303 View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2019

  1. New workaround for Chrome printing problem 

    This workaround (adding padding-top and negative margin-bottom on the before pseudo element of page-area/partition) is similar to the old workaround (adding padding-top on bleed-box ) but no problem of large images to disappear.

(The padding-top and negative margin-bottom value 0.015625px (1/64 px) is the minimum effective length on Chrome, I choose this value to minimize possible side effect.)
    @MurakamiShinyu
    MurakamiShinyu committed Apr 3, 2019
    Configuration menu
    Copy the full SHA
    9e0016e View commit details
    Browse the repository at this point in the history