Step1 use 3rdparty v3 #3554
Merged
Step1 use 3rdparty v3 #3554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sherman-the-tank
requested review from
yixinglu,
jiayuehua,
critical27 and
wenhaocs
sherman-the-tank
added
ready for review
ready-for-testing
1) Switched from HeaderClientChannel to the RocketChannel (common/thrif/ThriftClientManager-inc.h) 2) Fixed a bug in common/process/ProcessUtils.cpp 3) Fixed all UT 4) 99.9% of changes are mechanical: set_xxx(yyy) ==> xxx_ref() = yyy
sherman-the-tank
force-pushed
the
Step1-use-3rdparty-v3-2
branch
from
f6b19e5 to
fee6970
Compare
7 tasks
yixinglu
pushed a commit
to yixinglu/nebula
that referenced
this pull request
Mar 21, 2022
* Step1 use 3rdparty v3 (vesoft-inc#3554) * Switched to use third-party v3 1) Switched from HeaderClientChannel to the RocketChannel (common/thrif/ThriftClientManager-inc.h) 2) Fixed a bug in common/process/ProcessUtils.cpp 3) Fixed all UT 4) 99.9% of changes are mechanical: set_xxx(yyy) ==> xxx_ref() = yyy 5) Only allow empty functions on a single line * Solved merge conflicts 1) Solved merge conflicts 2) Solved ldap issues * Fixed lint error Co-authored-by: Sherman <sherman.ye@vesoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do?
Switched to use third-party v3
Which issue(s)/PR(s) this PR relates to?
Special notes for your reviewer, ex. impact of this fix, etc:
Additional context/ Design document:
Checklist:
Release notes:
Please confirm whether to be reflected in release notes and how to describe: