Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support alter schema in storage layer. #404

Closed
dangleptr opened this issue May 20, 2019 · 1 comment
Closed

Support alter schema in storage layer. #404

dangleptr opened this issue May 20, 2019 · 1 comment
Milestone
R201910_RC3

Comments

@dangleptr
Copy link
Contributor

dangleptr commented May 20, 2019 •
edited
Loading

Currently, we have supported alter one column's type in meta.
But we have't supported it yet in storage.

There are some questions must be answered before going on.

  1. How to do StatsQuery on multi version data?
    For example, we want to count sum on one column. But after the column's type changed, maybe we have many different types for related data, how to deal with it.

  2. How to deal with the response in query engine if one column in vertex data have different types. Now we don't deal with it.

  3. How to check if the filter is valid. Now we use the latest version of the schema.
@sherman-the-tank
Copy link
Member

I think based on the latest schema version is a valid assumption. So if the old version cannot be properly converted to the latest version during the calculation, we should just ignore that row

@jude-zhu jude-zhu added this to the R201910_RC1 milestone Aug 7, 2019
@jude-zhu jude-zhu modified the milestones: R201910_RC1, R201910_RC3 Nov 13, 2019
yixinglu pushed a commit to yixinglu/nebula that referenced this issue Mar 21, 2022
@nebula-bots @sherman-the-tank
Step1 use 3rdparty v3 (vesoft-inc#404)
fe6f62b 
* Step1 use 3rdparty v3 (vesoft-inc#3554)

* Switched to use third-party v3

1) Switched from HeaderClientChannel to the RocketChannel
   (common/thrif/ThriftClientManager-inc.h)
2) Fixed a bug in common/process/ProcessUtils.cpp
3) Fixed all UT
4) 99.9% of changes are mechanical: set_xxx(yyy)  ==> xxx_ref() = yyy
5) Only allow empty functions on a single line

* Solved merge conflicts

1) Solved merge conflicts
2) Solved ldap issues

* Fixed lint error

Co-authored-by: Sherman <sherman.ye@vesoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
R201910_RC3
Development

No branches or pull requests
3 participants
@sherman-the-tank @dangleptr @jude-zhu