Step 1: Switched to use third-party v3 #3407
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sherman-the-tank
changed the title
yixinglu
previously approved these changes
Dec 6, 2021
critical27
previously approved these changes
Dec 9, 2021
sherman-the-tank
dismissed stale reviews from critical27 and yixinglu
via
e3cb2fa
sherman-the-tank
force-pushed
the
Step1-use-3rdparty-v3
branch
2 times, most recently
from
e3cb2fa to
b507bf9
Compare
yixinglu
previously approved these changes
Dec 13, 2021
wenhaocs
previously approved these changes
Dec 16, 2021
sherman-the-tank
dismissed stale reviews from wenhaocs and yixinglu
via
cc22a86
sherman-the-tank
force-pushed
the
Step1-use-3rdparty-v3
branch
3 times, most recently
from
75ca674 to
1215345
Compare
1) Switched from HeaderClientChannel to the RocketChannel (common/thrif/ThriftClientManager-inc.h) 2) Fixed a bug in common/process/ProcessUtils.cpp 3) Fixed all UT 4) 99.9% of changes are mechanical: set_xxx(yyy) ==> xxx_ref() = yyy
sherman-the-tank
force-pushed
the
Step1-use-3rdparty-v3
branch
from
1215345 to
88788e1
Compare
wenhaocs
previously approved these changes
Dec 22, 2021
wenhaocs
previously approved these changes
Dec 23, 2021
sherman-the-tank
force-pushed
the
Step1-use-3rdparty-v3
branch
from
064a130 to
9606182
Compare
|
Abandon this PR. Use #3554 instead |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do?
This PR switched to ThirdParty v3
Which issue(s)/PR(s) this PR relates to?
Special notes for your reviewer, ex. impact of this fix, etc:
Additional context:
Checklist：
Release notes：
Please confirm whether to reflect in release notes and how to describe: