Try to fix "uninitialized" error

vesoft-inc · Dec 23, 2021 · 9606182 · 9606182
1 parent 058a350
commit 9606182
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/.github/workflows/pull_request.yml b/.github/workflows/pull_request.yml
@@ -125,7 +125,6 @@ jobs:
           esac
       - name: Make
         run: |
-          ccache -C
           ccache -z
           cmake --build build/ -j $(nproc)
           ccache -s

diff --git a/src/common/base/StatusOr.h b/src/common/base/StatusOr.h
@@ -290,16 +290,19 @@ class StatusOr final {
 
   void resetValue() {
     destructValue();
+    new (&variant_) Variant();
     state_ = kVoid;
   }
 
   void resetStatus() {
     destructStatus();
+    new (&variant_) Variant();
     state_ = kVoid;
   }
 
   void destruct() {
     if (isVoid()) {
+      destructStatus();
       return;
     }
     if (hasValue()) {
@@ -311,13 +314,14 @@ class StatusOr final {
 
   void reset() {
     destruct();
+    new (&variant_) Variant();
     state_ = kVoid;
   }
 
  private:
   // Variant type to hold a `Status', or a `T', or nothing
   union Variant {
-    Variant() {}
+    Variant() : status_(Status()) {}
     Variant(const Status &status) : status_(status) {}
     Variant(Status &&status) : status_(std::move(status)) {}
     template <typename U, typename = std::enable_if_t<is_initializable_v<U>>>