add bdd test on nebula cluster graceful termination #3252
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HarrisChu
reviewed
Nov 2, 2021
| @@ -0,0 +1,364 @@ | |||
| #!/usr/bin/python3 | |||
|
generally LGTM. additional two points:
I would follow these two. |
Aiee
reviewed
Nov 5, 2021
| Scenario: Basic termination test | ||
| Given a small nebula cluster | ||
| When the cluster was terminated | ||
| Then no service should still running after 4s |
There was a problem hiding this comment.
Please add the newline at the end of the file
CPWstatic
reviewed
Nov 18, 2021
| @@ -0,0 +1,8 @@ | |||
| @cluster | |||
There was a problem hiding this comment.
This annotation should deleted after all tests passed.
|
closed, @HarrisChu create a new pr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this pr add bdd integration test on issue #3005 #3122 and pr #3014