Fix storage hang on terminate #3014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liwenhui-soul
force-pushed
the
fix-storage-hang-on-terminate
branch
2 times, most recently
from
90d02b3 to
aa76a96
Compare
liuyu85cn
reviewed
Oct 9, 2021
liwenhui-soul
force-pushed
the
fix-storage-hang-on-terminate
branch
from
aa76a96 to
ee0517a
Compare
liuyu85cn
reviewed
Oct 9, 2021
liuyu85cn
reviewed
Oct 9, 2021
liuyu85cn
reviewed
Oct 9, 2021
liwenhui-soul
force-pushed
the
fix-storage-hang-on-terminate
branch
2 times, most recently
from
f05e215 to
a7327e5
Compare
|
Close #3005 |
liwenhui-soul
force-pushed
the
fix-storage-hang-on-terminate
branch
2 times, most recently
from
15465a8 to
1d10dcd
Compare
kikimo
reviewed
Oct 9, 2021
Codecov Report
@@ Coverage Diff @@
## master #3014 +/- ##
==========================================
+ Coverage 84.34% 84.36% +0.01%
==========================================
Files 1283 1283
Lines 113684 113699 +15
==========================================
+ Hits 95891 95923 +32
+ Misses 17793 17776 -17
Continue to review full report at Codecov.
|
liwenhui-soul
force-pushed
the
fix-storage-hang-on-terminate
branch
from
1d10dcd to
00d53f3
Compare
| std::vector<std::string> keys; | ||
| std::vector<futTuple> futVec; | ||
| for (; iter->valid(); iter->next()) { | ||
| folly::StringPiece key = iter->key(); | ||
| int32_t seqId = *reinterpret_cast<const int32_t*>(key.data()); | ||
| if (seqId < 0) continue; | ||
| if (seqId < 0) { |
There was a problem hiding this comment.
the key is consists of several items. would check it cast to integer?
| @@ -33,6 +33,7 @@ include_directories(AFTER ${CMAKE_CURRENT_BINARY_DIR}/src) | |||
|
|
|||
| if(ENABLE_WERROR) | |||
| add_compile_options(-Werror) | |||
| add_compile_options(-Wno-attributes) | |||
There was a problem hiding this comment.
why support this compile flag? which problem dose it solved?
critical27
approved these changes
Oct 11, 2021
Sophie-Xie
pushed a commit
that referenced
this pull request
Oct 12, 2021
* add -Wno-attribute, to avoid gcc's bug * break loop in unreportedAdminThread_ if the sever being stopped
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.