Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tck test cluster #3266

Merged
merged 8 commits into from
Nov 30, 2021
Merged

tck test cluster #3266

merged 8 commits into from
Nov 30, 2021

Conversation

HarrisChu
Copy link
Contributor

What type of PR is this?

  • bug
  • feature
  • [ x ] enhancement

What does this PR do?

enhance tck test framework, testing nebula cluster with 3 storaged.

Which issue(s)/PR(s) this PR relates to?

Special notes for your reviewer, ex. impact of this fix, etc:

Additional context:

Checklist:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatible (If it is incompatible, please describe it and add corresponding label.)
  • Need to cherry-pick (If need to cherry-pick to some branches, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to reflect in release notes and how to describe:

                                                            `

@HarrisChu HarrisChu added wip Solution: work in progress ready-for-testing PR: ready for the CI test labels Nov 3, 2021
@HarrisChu
Copy link
Contributor Author

have done:

  1. change default nebula cluster with 3 storaged, and then run original tck test cases.
  2. fix some features running in 3 storaged.

to be continued:

  1. migrate test cases for zone.
  2. migrate job feature with a normal test feature?

@Shylock-Hg
Copy link
Contributor

We should test single host and cluster together.

@HarrisChu
Copy link
Contributor Author

We should test single host and cluster together.

yes, just set the default Nebula as a cluster, and can test a single host at the case level.
e.g.
Given a nebulacluster with 1 graphd and 1 metad and 1 storaged

@HarrisChu HarrisChu requested a review from kikimo November 4, 2021 07:07
@HarrisChu
Copy link
Contributor Author

inspired by #3252

@HarrisChu HarrisChu removed the wip Solution: work in progress label Nov 6, 2021
@HarrisChu HarrisChu requested a review from yixinglu November 6, 2021 00:56
Copy link
Contributor

@yixinglu yixinglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great starting point for cluster testing.

tests/common/nebula_service.py Outdated Show resolved Hide resolved
tests/common/nebula_service.py Outdated Show resolved Hide resolved
@HarrisChu
Copy link
Contributor Author

cannot start nebula in SSL model, will check later

@codecov-commenter
Copy link

Codecov Report

Merging #3266 (e1514be) into master (fe68b0e) will decrease coverage by 0.03%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3266      +/-   ##
==========================================
- Coverage   85.27%   85.23%   -0.04%     
==========================================
  Files        1276     1276              
  Lines      118999   119004       +5     
==========================================
- Hits       101475   101434      -41     
- Misses      17524    17570      +46     
Impacted Files Coverage Δ
src/common/expression/ContainerExpression.cpp 90.00% <66.66%> (-2.13%) ⬇️
src/graph/validator/test/YieldValidatorTest.cpp 91.78% <100.00%> (ø)
src/parser/test/ParserTest.cpp 100.00% <100.00%> (ø)
src/meta/processors/parts/GetSpaceProcessor.cpp 60.60% <0.00%> (-18.19%) ⬇️
src/meta/processors/BaseProcessor.h 75.67% <0.00%> (-16.22%) ⬇️
src/graph/context/Result.cpp 85.00% <0.00%> (-9.45%) ⬇️
src/common/thrift/ThriftClientManager-inl.h 82.97% <0.00%> (-6.39%) ⬇️
...eta/processors/session/SessionManagerProcessor.cpp 74.19% <0.00%> (-4.52%) ⬇️
src/graph/executor/StorageAccessExecutor.h 66.66% <0.00%> (-2.57%) ⬇️
src/storage/mutate/AddVerticesProcessor.cpp 85.64% <0.00%> (-2.40%) ⬇️
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8872973...e1514be. Read the comment docs.

@HarrisChu HarrisChu mentioned this pull request Nov 30, 2021
Copy link
Contributor

@yixinglu yixinglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants