RC4 Cherrypick #2031 #2042 #2025 #2013 #2038 #2051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: dutor <440396+dutor@users.noreply.github.com> (cherry picked from commit 3423df1)
Co-authored-by: dutor <440396+dutor@users.noreply.github.com> (cherry picked from commit eea7407)
* Sampling from all edges. * Update test for sampling multi edges. * Testing both inbound and outbound. * Fix clang compiling problem. * Update the sampling. Co-authored-by: dutor <440396+dutor@users.noreply.github.com> (cherry picked from commit 8810ecc)
* Fix the error when vertex/edge not exist if update. * Optimize the atomic error logical. * Fix one alignment. Co-authored-by: dutor <440396+dutor@users.noreply.github.com> (cherry picked from commit 9fc4e7f)
| @@ -142,7 +142,7 @@ nebula::cpp2::SupportedType TraverseExecutor::calculateExprType(Expression* exp) | |||
| case Expression::kInputProp: { | |||
| auto* propExp = static_cast<const AliasPropertyExpression*>(exp); | |||
| const auto* propName = propExp->prop(); | |||
| if (inputs_ == nullptr) { | |||
| if (inputs_ == nullptr || !inputs_->hasData()) { | |||
There was a problem hiding this comment.
if inputs_ == nullptr , Is it will leads to crash by inputs_->hasData() ?
There was a problem hiding this comment.
I think won't because the short circuit ||
…at. (vesoft-inc#2038) * Correct issue 2009 which the timestamp default value for edge not treat. * Add the cover cases. * Fix one typo. Co-authored-by: dutor <440396+dutor@users.noreply.github.com> (cherry picked from commit 4aa9217)
jude-zhu
changed the title
Codecov Report
@@ Coverage Diff @@
## v1.0.0-rc4 #2051 +/- ##
=============================================
Coverage ? 86.73%
=============================================
Files ? 641
Lines ? 61104
Branches ? 0
=============================================
Hits ? 52998
Misses ? 8106
Partials ? 0 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherrypick #2031 #2042 #2025 #2013 #2038