Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove bigint because we dont support it #2031

Merged
merged 2 commits into from
Apr 2, 2020
Merged

Conversation

knightXun
Copy link
Contributor

No description provided.

@knightXun
Copy link
Contributor Author

knightXun commented Mar 31, 2020

I believe this is a bug.
image

@knightXun knightXun requested review from dutor, panda-sheep and laura-ding and removed request for dutor and panda-sheep March 31, 2020 15:24
Copy link
Contributor

@laura-ding laura-ding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! @Amber1990Zhang The doc about the keyword needs to remove the BIGINT.

@laura-ding laura-ding added the ready-for-testing PR: ready for the CI test label Apr 1, 2020
@codecov-io
Copy link

codecov-io commented Apr 1, 2020

Codecov Report

Merging #2031 into master will decrease coverage by 0.14%.
The diff coverage is 93.18%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2031      +/-   ##
==========================================
- Coverage   86.90%   86.75%   -0.15%     
==========================================
  Files         636      641       +5     
  Lines       59819    61106    +1287     
==========================================
+ Hits        51984    53013    +1029     
- Misses       7835     8093     +258     
Impacted Files Coverage Δ
src/common/base/Configuration.h 100.00% <ø> (ø)
src/common/filter/Expressions.h 89.48% <ø> (+2.02%) ⬆️
src/common/utils/NebulaKeyUtils.cpp 100.00% <ø> (ø)
src/common/utils/NebulaKeyUtils.h 90.41% <ø> (ø)
src/common/utils/test/NebulaKeyUtilsTest.cpp 97.10% <ø> (ø)
src/graph/DescribeSpaceExecutor.h 0.00% <ø> (ø)
src/graph/FetchEdgesExecutor.h 0.00% <ø> (ø)
src/graph/FetchExecutor.cpp 88.88% <ø> (+0.59%) ⬆️
src/graph/FetchVerticesExecutor.h 0.00% <ø> (ø)
src/graph/GoExecutor.h 56.25% <ø> (ø)
... and 206 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eea7407...c5e6849. Read the comment docs.

@jude-zhu jude-zhu requested a review from Shylock-Hg April 1, 2020 09:10
Copy link
Contributor

@Shylock-Hg Shylock-Hg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Shylock-Hg Shylock-Hg linked an issue Apr 2, 2020 that may be closed by this pull request
@dutor dutor changed the title remove bigint because we dont realize it remove bigint because we dont support it Apr 2, 2020
@dutor dutor merged commit 3423df1 into vesoft-inc:master Apr 2, 2020
jude-zhu pushed a commit to jude-zhu/nebula that referenced this pull request Apr 2, 2020
Co-authored-by: dutor <440396+dutor@users.noreply.github.com>
(cherry picked from commit 3423df1)
dutor pushed a commit that referenced this pull request Apr 2, 2020
* remove bigint because we dont support it (#2031)

Co-authored-by: dutor <440396+dutor@users.noreply.github.com>
(cherry picked from commit 3423df1)

* fix crash (#2042)

Co-authored-by: dutor <440396+dutor@users.noreply.github.com>
(cherry picked from commit eea7407)

* Sampling apply to all edges starting from a vertex. (#2013)

* Sampling from all edges.

* Update test for sampling multi edges.

* Testing both inbound and outbound.

* Fix clang compiling problem.

* Update the sampling.

Co-authored-by: dutor <440396+dutor@users.noreply.github.com>
(cherry picked from commit 8810ecc)

* Fix the error when vertex/edge not exist if update. (#2025)

* Fix the error when vertex/edge not exist if update.

* Optimize the atomic error logical.

* Fix one alignment.

Co-authored-by: dutor <440396+dutor@users.noreply.github.com>
(cherry picked from commit 9fc4e7f)

* Correct issue 2009 which the timestamp default value for edge not treat. (#2038)

* Correct issue 2009 which the timestamp default value for edge not treat.

* Add the cover cases.

* Fix one typo.

Co-authored-by: dutor <440396+dutor@users.noreply.github.com>
(cherry picked from commit 4aa9217)

Co-authored-by: flyingcat <1004815462@qq.com>
Co-authored-by: laura-ding <48548375+laura-ding@users.noreply.github.com>
Co-authored-by: CPWstatic <13495049+CPWstatic@users.noreply.github.com>
Co-authored-by: Shylock Hg <33566796+Shylock-Hg@users.noreply.github.com>
tong-hao pushed a commit to tong-hao/nebula that referenced this pull request Jun 1, 2021
Co-authored-by: dutor <440396+dutor@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

create screma with bigint should not succeed
5 participants