Fix the error when vertex/edge not exist if update. #2025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Shylock-Hg
requested review from
dangleptr,
bright-starry-sky,
CPWstatic,
darionyaphet,
dutor,
jude-zhu,
knightXun,
laura-ding and
monadbobo
dangleptr
reviewed
Mar 31, 2020
dangleptr
previously approved these changes
Apr 1, 2020
| FilterResult UpdateEdgeProcessor::checkFilter(const PartitionID partId, | ||
| const cpp2::EdgeKey& edgeKey) { | ||
| cpp2::ErrorCode UpdateEdgeProcessor::checkFilter(const PartitionID partId, | ||
| const cpp2::EdgeKey& edgeKey) { |
| @@ -70,7 +70,7 @@ class UpdateVertexProcessor | |||
| std::unordered_map<TagID, std::unique_ptr<KeyUpdaterPair>> tagUpdaters_; | |||
| meta::IndexManager* indexMan_{nullptr}; | |||
| std::vector<std::shared_ptr<nebula::cpp2::IndexItem>> indexes_; | |||
| std::atomic<FilterResult> filterResult_{FilterResult::E_ERROR}; | |||
| std::atomic<cpp2::ErrorCode> filterResult_{cpp2::ErrorCode::SUCCEEDED}; | |||
There was a problem hiding this comment.
Reach the line length limit.
| @@ -68,7 +68,7 @@ class UpdateEdgeProcessor | |||
| std::unique_ptr<RowUpdater> updater_; | |||
| meta::IndexManager* indexMan_{nullptr}; | |||
| std::vector<std::shared_ptr<nebula::cpp2::IndexItem>> indexes_; | |||
| std::atomic<FilterResult> filterResult_{FilterResult::E_ERROR}; | |||
| std::atomic<cpp2::ErrorCode> filterResult_{cpp2::ErrorCode::SUCCEEDED}; | |||
There was a problem hiding this comment.
Reach the line length limit.
dangleptr
approved these changes
Apr 1, 2020
jude-zhu
pushed a commit
to jude-zhu/nebula
that referenced
this pull request
Apr 2, 2020
* Fix the error when vertex/edge not exist if update. * Optimize the atomic error logical. * Fix one alignment. Co-authored-by: dutor <440396+dutor@users.noreply.github.com> (cherry picked from commit 9fc4e7f)
dutor
pushed a commit
that referenced
this pull request
Apr 2, 2020
* remove bigint because we dont support it (#2031) Co-authored-by: dutor <440396+dutor@users.noreply.github.com> (cherry picked from commit 3423df1) * fix crash (#2042) Co-authored-by: dutor <440396+dutor@users.noreply.github.com> (cherry picked from commit eea7407) * Sampling apply to all edges starting from a vertex. (#2013) * Sampling from all edges. * Update test for sampling multi edges. * Testing both inbound and outbound. * Fix clang compiling problem. * Update the sampling. Co-authored-by: dutor <440396+dutor@users.noreply.github.com> (cherry picked from commit 8810ecc) * Fix the error when vertex/edge not exist if update. (#2025) * Fix the error when vertex/edge not exist if update. * Optimize the atomic error logical. * Fix one alignment. Co-authored-by: dutor <440396+dutor@users.noreply.github.com> (cherry picked from commit 9fc4e7f) * Correct issue 2009 which the timestamp default value for edge not treat. (#2038) * Correct issue 2009 which the timestamp default value for edge not treat. * Add the cover cases. * Fix one typo. Co-authored-by: dutor <440396+dutor@users.noreply.github.com> (cherry picked from commit 4aa9217) Co-authored-by: flyingcat <1004815462@qq.com> Co-authored-by: laura-ding <48548375+laura-ding@users.noreply.github.com> Co-authored-by: CPWstatic <13495049+CPWstatic@users.noreply.github.com> Co-authored-by: Shylock Hg <33566796+Shylock-Hg@users.noreply.github.com>
tong-hao
pushed a commit
to tong-hao/nebula
that referenced
this pull request
Jun 1, 2021
* Fix the error when vertex/edge not exist if update. * Optimize the atomic error logical. * Fix one alignment. Co-authored-by: dutor <440396+dutor@users.noreply.github.com>
yixinglu
pushed a commit
to yixinglu/nebula
that referenced
this pull request
Jan 31, 2023
* memory tracker * refine code * refine code * add check * fix sanitize * add check * fix build * fix build * fix sanitize issues * minor, delete debug log * storage add memmory tracker * add more check & add memory stats log flag * fix lint & memory monitor name in storaged * refine catch in scheduler * move try catch on stack up in Storage's processors * remove unused include * fix build * add jemalloc compile flag & MemTracker is use only when jemalloc is avalable, depends on jemalloc to get accurate free size * add memory track in LookupProcessor.cpp * refine code * fix lint * fix build Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com> Co-authored-by: codesigner <codesigner.huang@vesoft.com> Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Why are the changes needed?
Does this PR introduce any user-facing change?
How was this patch tested?