apacheGH-41061: [C++] Ignore ARROW_USE_MOLD/ARROW_USE_LLD with clang …

…< 12 (apache#41062) ### Rationale for this change `--ld-path` is available since clang 12 or later. ### What changes are included in this PR? Ignore `ARROW_USE_MOLD`/`ARROW_USE_LLD` with clang < 12. ### Are these changes tested? Yes. ### Are there any user-facing changes? Yes. * GitHub Issue: apache#41061 Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
verma-kartik · Apr 11, 2024 · 9403dcc · 9403dcc
1 parent 3da625e
commit 9403dcc
Showing 1 changed file with 13 additions and 4 deletions.
diff --git a/cpp/cmake_modules/SetupCxxFlags.cmake b/cpp/cmake_modules/SetupCxxFlags.cmake
@@ -640,19 +640,23 @@ if(NOT WIN32 AND NOT APPLE)
       if(CMAKE_CXX_COMPILER_ID STREQUAL "GNU")
         if(CMAKE_CXX_COMPILER_VERSION VERSION_GREATER_EQUAL "12.1.0")
           set(MOLD_LINKER_FLAGS "-fuse-ld=mold")
-          message(STATUS "Using optional mold linker")
         else()
           message(STATUS "Need GCC 12.1.0 or later to use mold linker: ${CMAKE_CXX_COMPILER_VERSION}"
           )
         endif()
       elseif(CMAKE_CXX_COMPILER_ID STREQUAL "Clang")
-        set(MOLD_LINKER_FLAGS "--ld-path=${LD_MOLD}")
-        message(STATUS "Using optional mold linker")
+        if(CMAKE_CXX_COMPILER_VERSION VERSION_GREATER_EQUAL "12.0.0")
+          set(MOLD_LINKER_FLAGS "--ld-path=${LD_MOLD}")
+        else()
+          message(STATUS "Need clang 12.0.0 or later to use mold linker: ${CMAKE_CXX_COMPILER_VERSION}"
+          )
+        endif()
       else()
         message(STATUS "Using the default linker because compiler doesn't support mold: ${CMAKE_CXX_COMPILER_ID}"
         )
       endif()
       if(MOLD_LINKER_FLAGS)
+        message(STATUS "Using optional mold linker")
         string(APPEND CMAKE_EXE_LINKER_FLAGS " ${MOLD_LINKER_FLAGS}")
         string(APPEND CMAKE_MODULE_LINKER_FLAGS " ${MOLD_LINKER_FLAGS}")
         string(APPEND CMAKE_SHARED_LINKER_FLAGS " ${MOLD_LINKER_FLAGS}")
@@ -675,7 +679,12 @@ if(ARROW_USE_LLD)
         )
       endif()
     elseif(CMAKE_CXX_COMPILER_ID STREQUAL "Clang")
-      set(LLD_LINKER_FLAGS "--ld-path=${LD_LLD}")
+      if(CMAKE_CXX_COMPILER_VERSION VERSION_GREATER_EQUAL "12.0.0")
+        set(LLD_LINKER_FLAGS "--ld-path=${LD_LLD}")
+      else()
+        message(STATUS "Need clang 12.0.0 or later to use LLD linker: ${CMAKE_CXX_COMPILER_VERSION}"
+        )
+      endif()
     else()
       message(STATUS "Using the default linker because compiler doesn't support LLD: ${CMAKE_CXX_COMPILER_ID}"
       )