GH-41061: [C++] Ignore ARROW_USE_MOLD/ARROW_USE_LLD with clang < 12 #41062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…< 12 Because `--ld-path` is available since clang 12 or later.
|
@github-actions crossbow submit -g cpp |
|
|
github-actions
bot
added
Component: C++
awaiting committer review
|
Revision: 4fc2c8e Submitted crossbow builds: ursacomputing/crossbow @ actions-958d199ae8
|
|
+1 |
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 1343ac7. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
verma-kartik
pushed a commit
to verma-kartik/arrow
that referenced
this pull request
Apr 11, 2024
…< 12 (apache#41062) ### Rationale for this change `--ld-path` is available since clang 12 or later. ### What changes are included in this PR? Ignore `ARROW_USE_MOLD`/`ARROW_USE_LLD` with clang < 12. ### Are these changes tested? Yes. ### Are there any user-facing changes? Yes. * GitHub Issue: apache#41061 Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
tolleybot
pushed a commit
to tmct/arrow
that referenced
this pull request
May 2, 2024
…< 12 (apache#41062) ### Rationale for this change `--ld-path` is available since clang 12 or later. ### What changes are included in this PR? Ignore `ARROW_USE_MOLD`/`ARROW_USE_LLD` with clang < 12. ### Are these changes tested? Yes. ### Are there any user-facing changes? Yes. * GitHub Issue: apache#41061 Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
tolleybot
pushed a commit
to tmct/arrow
that referenced
this pull request
May 4, 2024
…< 12 (apache#41062) ### Rationale for this change `--ld-path` is available since clang 12 or later. ### What changes are included in this PR? Ignore `ARROW_USE_MOLD`/`ARROW_USE_LLD` with clang < 12. ### Are these changes tested? Yes. ### Are there any user-facing changes? Yes. * GitHub Issue: apache#41061 Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
rok
pushed a commit
to tmct/arrow
that referenced
this pull request
May 8, 2024
…< 12 (apache#41062) ### Rationale for this change `--ld-path` is available since clang 12 or later. ### What changes are included in this PR? Ignore `ARROW_USE_MOLD`/`ARROW_USE_LLD` with clang < 12. ### Are these changes tested? Yes. ### Are there any user-facing changes? Yes. * GitHub Issue: apache#41061 Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
rok
pushed a commit
to tmct/arrow
that referenced
this pull request
May 8, 2024
…< 12 (apache#41062) ### Rationale for this change `--ld-path` is available since clang 12 or later. ### What changes are included in this PR? Ignore `ARROW_USE_MOLD`/`ARROW_USE_LLD` with clang < 12. ### Are these changes tested? Yes. ### Are there any user-facing changes? Yes. * GitHub Issue: apache#41061 Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
vibhatha
pushed a commit
to vibhatha/arrow
that referenced
this pull request
May 25, 2024
…< 12 (apache#41062) ### Rationale for this change `--ld-path` is available since clang 12 or later. ### What changes are included in this PR? Ignore `ARROW_USE_MOLD`/`ARROW_USE_LLD` with clang < 12. ### Are these changes tested? Yes. ### Are there any user-facing changes? Yes. * GitHub Issue: apache#41061 Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
--ld-pathis available since clang 12 or later.What changes are included in this PR?
Ignore
ARROW_USE_MOLD/ARROW_USE_LLDwith clang < 12.Are these changes tested?
Yes.
Are there any user-facing changes?
Yes.
--ld-path#41061