Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++] clang < 12 doesn't have --ld-path #41061

Closed
kou opened this issue Apr 8, 2024 · 1 comment
Closed

[C++] clang < 12 doesn't have --ld-path #41061

kou opened this issue Apr 8, 2024 · 1 comment
Assignees
@kou
Labels
Component: C++ Type: bug
Milestone
16.0.0

Comments

@kou
Copy link
Member

kou commented Apr 8, 2024

Describe the bug, including details regarding any error messages, version, and platform.

test-ubuntu-20.04-cpp-thread-sanitizer:

https://github.com/ursacomputing/crossbow/actions/runs/8592709908/job/23543129306#step:7:4526

...
-- Looking for pthread.h
-- Looking for pthread.h - not found
CMake Error at /usr/share/cmake-3.16/Modules/FindPackageHandleStandardArgs.cmake:146 (message):
  Could NOT find Threads (missing: Threads_FOUND)
Call Stack (most recent call first):
  /usr/share/cmake-3.16/Modules/FindPackageHandleStandardArgs.cmake:393 (_FPHSA_FAILURE_MESSAGE)
  /usr/share/cmake-3.16/Modules/FindThreads.cmake:220 (FIND_PACKAGE_HANDLE_STANDARD_ARGS)
  cmake_modules/ThirdpartyToolchain.cmake:1057 (find_package)
  CMakeLists.txt:543 (include)


-- Configuring incomplete, errors occurred!
See also "/build/cpp/CMakeFiles/CMakeOutput.log".
See also "/build/cpp/CMakeFiles/CMakeError.log".
Error: docker run --rm -e SETUPTOOLS_SCM_PRETEND_VERSION=16.0.0.dev470 --shm-size 2147483648 -e ARROW_BUILD_STATIC=OFF -e ARROW_CTEST_TIMEOUT=500 -e ARROW_DATASET=ON -e ARROW_JEMALLOC=OFF -e ARROW_ORC=OFF -e ARROW_S3=OFF -e ARROW_USE_TSAN=ON -e AWS_ACCESS_KEY_ID=*** -e AWS_SECRET_ACCESS_KEY=*** -e CC=clang-11 -e CCACHE_COMPILERCHECK=content -e CCACHE_COMPRESS=1 -e CCACHE_COMPRESSLEVEL=6 -e CCACHE_DIR=/ccache -e CCACHE_MAXSIZE=1G -e CXX=clang++-11 -e GITHUB_ACTIONS=true -e SCCACHE_BUCKET=*** -e SCCACHE_REGION=*** -e SCCACHE_S3_KEY_PREFIX=sccache -v /home/runner/work/crossbow/crossbow/arrow:/arrow -v ubuntu-ccache:/ccache apache/arrow-dev:amd64-ubuntu-20.04-cpp /bin/bash -c   /arrow/ci/scripts/cpp_build.sh /arrow /build &&
  /arrow/ci/scripts/integration_skyhook.sh /build &&
  /arrow/ci/scripts/cpp_test.sh /arrow /build exited with non-zero exit code 1

Component(s)

C++
@kou kou added the Type: bug label Apr 8, 2024
kou added a commit to kou/arrow that referenced this issue Apr 8, 2024
@kou
apacheGH-41061: [C++] Ignore ARROW_USE_MOLD/ARROW_USE_LLD with clang …
4fc2c8e 
…< 12

Because `--ld-path` is available since clang 12 or later.
@github-actions github-actions bot mentioned this issue Apr 8, 2024
Merged
kou added a commit that referenced this issue Apr 8, 2024
@kou
GH-41061: [C++] Ignore ARROW_USE_MOLD/ARROW_USE_LLD with clang < 12 (#…
1343ac7 
…41062)

### Rationale for this change

`--ld-path` is available since clang 12 or later.

### What changes are included in this PR?

Ignore `ARROW_USE_MOLD`/`ARROW_USE_LLD` with clang < 12.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

Yes.
* GitHub Issue: #41061

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@kou kou added this to the 16.0.0 milestone Apr 8, 2024
@kou
Copy link
Member Author

kou commented Apr 8, 2024

Issue resolved by pull request 41062
#41062

@kou kou closed this as completed Apr 8, 2024
verma-kartik pushed a commit to verma-kartik/arrow that referenced this issue Apr 11, 2024
@kou @verma-kartik
apacheGH-41061: [C++] Ignore ARROW_USE_MOLD/ARROW_USE_LLD with clang …
9403dcc 
…< 12 (apache#41062)

### Rationale for this change

`--ld-path` is available since clang 12 or later.

### What changes are included in this PR?

Ignore `ARROW_USE_MOLD`/`ARROW_USE_LLD` with clang < 12.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

Yes.
* GitHub Issue: apache#41061

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
tolleybot pushed a commit to tmct/arrow that referenced this issue May 2, 2024
@kou @tolleybot
apacheGH-41061: [C++] Ignore ARROW_USE_MOLD/ARROW_USE_LLD with clang …
c6edd23 
…< 12 (apache#41062)

### Rationale for this change

`--ld-path` is available since clang 12 or later.

### What changes are included in this PR?

Ignore `ARROW_USE_MOLD`/`ARROW_USE_LLD` with clang < 12.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

Yes.
* GitHub Issue: apache#41061

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
tolleybot pushed a commit to tmct/arrow that referenced this issue May 4, 2024
@kou @tolleybot
apacheGH-41061: [C++] Ignore ARROW_USE_MOLD/ARROW_USE_LLD with clang …
19bfeb5 
…< 12 (apache#41062)

### Rationale for this change

`--ld-path` is available since clang 12 or later.

### What changes are included in this PR?

Ignore `ARROW_USE_MOLD`/`ARROW_USE_LLD` with clang < 12.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

Yes.
* GitHub Issue: apache#41061

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
rok pushed a commit to tmct/arrow that referenced this issue May 8, 2024
@kou @rok
apacheGH-41061: [C++] Ignore ARROW_USE_MOLD/ARROW_USE_LLD with clang …
b53258e 
…< 12 (apache#41062)

### Rationale for this change

`--ld-path` is available since clang 12 or later.

### What changes are included in this PR?

Ignore `ARROW_USE_MOLD`/`ARROW_USE_LLD` with clang < 12.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

Yes.
* GitHub Issue: apache#41061

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
rok pushed a commit to tmct/arrow that referenced this issue May 8, 2024
@kou @rok
apacheGH-41061: [C++] Ignore ARROW_USE_MOLD/ARROW_USE_LLD with clang …
3a7409d 
…< 12 (apache#41062)

### Rationale for this change

`--ld-path` is available since clang 12 or later.

### What changes are included in this PR?

Ignore `ARROW_USE_MOLD`/`ARROW_USE_LLD` with clang < 12.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

Yes.
* GitHub Issue: apache#41061

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
vibhatha pushed a commit to vibhatha/arrow that referenced this issue May 25, 2024
@kou @vibhatha
apacheGH-41061: [C++] Ignore ARROW_USE_MOLD/ARROW_USE_LLD with clang …
fad94bd 
…< 12 (apache#41062)

### Rationale for this change

`--ld-path` is available since clang 12 or later.

### What changes are included in this PR?

Ignore `ARROW_USE_MOLD`/`ARROW_USE_LLD` with clang < 12.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

Yes.
* GitHub Issue: apache#41061

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kou kou

Labels
Component: C++ Type: bug
Projects
None yet
Milestone
16.0.0
Development

No branches or pull requests
1 participant
@kou