Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sentences and lower case tuning #25

Merged
merged 7 commits into from
Jun 15, 2023
Merged

Sentences and lower case tuning #25

merged 7 commits into from
Jun 15, 2023

Conversation

kurudrive
Copy link
Member

@kurudrive kurudrive commented Jun 13, 2023

ブロック名の単語の最初の文字を大文字に統一したのとブロックの説明の微調整のみです

Sentences and lower case tuning

@kurudrive kurudrive requested a review from shimotmk June 13, 2023 14:39
@kurudrive kurudrive changed the title 各種表示テキストの微調整 【確認待ち】各種表示テキストの微調整 Jun 13, 2023
@shimotmk
Copy link
Contributor

@kurudrive
Thank you for your correction.
However, if I want to fix it, I would like to match it with the core (Gutenberg).

Copy Button setting → Settings
WordPress/gutenberg#40275

I don't think it's a good idea to use capital letters in sentences.
WordPress/gutenberg#8888
https://github.com/WordPress/gutenberg/blob/trunk/docs/contributors/documentation/copy-guide.md#five-pay-attention-to-capitalization

Inner block → Inner blocks
https://github.com/WordPress/gutenberg/blob/fa3233c114da83b93da8d9da176425516511e64c/packages/block-editor/src/hooks/layout.js#L164

@kurudrive kurudrive marked this pull request as draft June 14, 2023 09:16
@kurudrive
Copy link
Member Author

@shimotmk

Thank you for your review.

Copy Button setting → Settings
Inner block → Inner blocks

Oh, I see, you have huge knowledge with Gutenberg.
I fixed it!!

I don't think it's a good idea to use capital letters in sentences.

I see, but ... the reason of I was changed it was block name is "noun".
( This is to make it easier for users to understand that it is a "block name". )
WordPress is not write "Wordpress" right?

I'll let you make the final decision about this repository.

@kurudrive kurudrive marked this pull request as ready for review June 14, 2023 09:46
@shimotmk
Copy link
Contributor

@kurudrive

WordPress is not write "Wordpress" right?

That is an incontestable truth.

There was lowercase case when using block titles in sentences.
https://github.com/WordPress/gutenberg/blob/74d6b30b10814f589e5c957ee12071a94610eabc/packages/block-library/src/column/block.json#L7

My native language is Japanese, so I can't judge what's natural.
So I checked the core rules.

@kurudrive
Copy link
Member Author

There was lowercase case when using block titles in sentences.
https://github.com/WordPress/gutenberg/blob/74d6b30b10814f589e5c957ee12071a94610eabc/packages/block-library/src/column/block.json#L7

I see. you are right 👍
In the sentences, the core using lower case about block name too, therefore I agree with use lower case.

I'll fix it.
just a moment :)

@kurudrive
Copy link
Member Author

@shimotmk Fixed it 🙂

@kurudrive kurudrive changed the title 【確認待ち】各種表示テキストの微調整 【確認待ち】Sentences and lower case tuning Jun 15, 2023
Copy link
Contributor

@shimotmk shimotmk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.
I think it's good, so I'm merging it.

@shimotmk shimotmk merged commit 9b0f4ff into main Jun 15, 2023
@shimotmk shimotmk deleted the update/translate branch June 15, 2023 05:44
@kurudrive kurudrive changed the title 【確認待ち】Sentences and lower case tuning Sentences and lower case tuning Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants