Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooltip labels: inconstency in case style #8888

Closed
eliorivero opened this issue Aug 12, 2018 · 5 comments
Closed

Tooltip labels: inconstency in case style #8888

eliorivero opened this issue Aug 12, 2018 · 5 comments
Labels
[Type] Copy Issues or PRs that need copy editing assistance [Type] Enhancement A suggestion for improvement.

Comments

@eliorivero
Copy link
Contributor

eliorivero commented Aug 12, 2018

Describe the bug
The texts used in different tooltips are different regarding the case they use:

  • some use sentence case
    captura de pantalla 2018-08-11 a la s 19 05 07captura de pantalla 2018-08-11 a la s 19 05 01

  • others use title case
    captura de pantalla 2018-08-11 a la s 21 26 00captura de pantalla 2018-08-11 a la s 21 27 06captura de pantalla 2018-08-13 a la s 12 22 44

  • and others are composed in lowercase
    captura de pantalla 2018-08-11 a la s 21 18 34

To Reproduce
Steps to reproduce the behavior:

  1. roll the mouse over some of the elements shown in the images above.

Expected behavior
Consistency in the case style used in all tooltips.

Happy to work on this unifying the case style but would like to know which standard to go with. I know that WordPress core uses the title case, but given that these are tooltips and not titles, maybe it's better to use sentence case. Color names should probably be capitalized using sentence case too.
I checked the Classic Editor to see if a style was consistently used there, but there are discrepancies there too:
captura de pantalla 2018-08-11 a la s 21 23 13captura de pantalla 2018-08-11 a la s 21 23 23captura de pantalla 2018-08-11 a la s 21 24 34

@chrisvanpatten
Copy link
Contributor

Thanks @eliorivero! There's some information on our casing preferences in the docs.

I think most of the cases you shared are valid per the guidelines, but there are two cases you highlighted that seem like they could improve, so I want to get @karmatosed and @michelleweber's help on these:

  • More Options vs More options — I like the sentence case version but there's definitely a case (ha!) for the Title Case version
  • Should we auto-capitalise color names when they're displayed in tooltips?

Thanks again for the ticket!

@chrisvanpatten chrisvanpatten added [Type] Copy Issues or PRs that need copy editing assistance [Type] Enhancement A suggestion for improvement. labels Aug 12, 2018
@michelleweber
Copy link

I'd go sentence case; it's what tooltips in the current editor do, and title case is really best saved for actual titles. I'd sentence case the color names as well.

@eliorivero
Copy link
Contributor Author

Thanks @chrisvanpatten and @michelleweber for the response! Will update as Michelle says, using sentence case for all tooltips 👍

@chrisvanpatten
Copy link
Contributor

@eliorivero Thanks! The only thing I think is that the Classic Editor block button tooltips might need to stay for backcompat with the old editor, and because "Document Structure" is a feature (as opposed to an action like the other tooltips) I think it would stay as Title Case. Of course I'm happy to be corrected on either point!

@eliorivero
Copy link
Contributor Author

Thanks, I'm not touching the classic editor. However, I'm typing "Document Structure" as "Document structure" since unlike the "Close Publish Panel", which I typed now as "Close Publish panel", the "structure" here is not a panel or a specific feature name on its own.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Copy Issues or PRs that need copy editing assistance [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

3 participants