Remove redundant block name from "settings" panels #40275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -66 B (0%) Total Size: 1.22 MB
ℹ️ View Unchanged
|
ZebulanStanphill
approved these changes
Apr 12, 2022
|
Thank you all for the feedback and reviews! I'll restart the test and see if it can land. I do agree that there's more work we can do here. In some cases, a "Settings" panel itself is redundant, especially for blocks that have very few and very specific options: the need to be able to collapse a panel is likely to never be used. This idea for a "child pages" toggle on the Page List never materialized and the mockup is obsolete, but it does show how in some cases a whole panel just for one toggle itself feels redundant:
"General" or another label could also benefit. I wanted to start very simple, though, and since many blocks have "Settings" panels, the word is likely to be well translated by now. So this could be seen as a first step. Finally, there's #40204 to consider. If you don't mind, I'll land this one when the checks pass, but I'm happy to do followups. |
We should also take the case of plugins that can extend the Settings panel with general settings related to blocks. In general, we should seek ways to make it more organized so user can customize what's exposed by default like it's possible with Global Styles related sections. |
Yes, just like there's an effort to have a single and reused Dimensions panel across blocks (#28356), it makes sense to have a space for general block settings that might be unique to that one particular block. Whether it needs to be able to collapse or not, I don't know, and I imagie 40204 could also further that discussion. |
ZebulanStanphill
added a commit
that referenced
this pull request
Apr 14, 2022
priethor
added
[Type] Code Quality
ZebulanStanphill
added a commit
that referenced
this pull request
Apr 27, 2022
ZebulanStanphill
added a commit
that referenced
this pull request
Apr 28, 2022
ZebulanStanphill
added a commit
that referenced
this pull request
May 4, 2022
ZebulanStanphill
added a commit
that referenced
this pull request
May 5, 2022
This was referenced Oct 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Across the core block library, we have numerous settings panels containing various block-specific controls, many of which are named
[block name] settings, for example "Media & Text settings", "Latest Comments settings" or "Archives settings".Aside from being clunky to read, the block name is redundant since it's the top card of the block inspector, shown right above the very same panel:
This PR removes the block name across virtually all blocks in the library. In addition, it fixes a few inconsistencies where some panels would use sentence case, some would use title case, and still others would use sentence case but with blocks capitalized.
Why?
In reducing redundancy, it reduces noise, and allows for a generic "Settings" panel to be consistent across blocks.
Testing Instructions
Test the block inspectors for the following blocks:
Screenshots or screencast
The following screenshots all show the inspector with this PR applied:
