fix: use ariaTarget property to set popover ARIA attributes if possible #8721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web-padawan
force-pushed
the
feat/popover-aria-target
branch
from
dd22eec to
465d625
Compare
web-padawan
changed the title
sissbruecker
approved these changes
Feb 25, 2025
|
vaadin-bot
pushed a commit
that referenced
this pull request
Feb 25, 2025
vaadin-bot
pushed a commit
that referenced
this pull request
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #8703
AddedariaTargetproperty similar to the one that was previously added forvaadin-tooltipin #6320.Example: when using
vaadin-text-fieldas a popover target, usetextField.inputElementasariaTarget.UPD: as suggested #8721 (comment), changed to use
target.ariaTargetif possible.This would be somewhat aligned with #8732 where we use
target.focusElement.Also, changed the popover observers a bit to make it easier to remove ARIA attributes when clearing target.
Type of change