fix: check if popover target has focusElement as focusable #8732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web-padawan
changed the title
web-padawan
force-pushed
the
fix/popover-tab-order-focus-element
branch
from
c96da05 to
dfc636f
Compare
|
sissbruecker
approved these changes
Feb 26, 2025
vaadin-bot
pushed a commit
that referenced
this pull request
Feb 26, 2025
vaadin-bot
pushed a commit
that referenced
this pull request
Feb 26, 2025
vaadin-bot
pushed a commit
that referenced
this pull request
Feb 26, 2025
web-padawan
added a commit
that referenced
this pull request
Feb 26, 2025
web-padawan
added a commit
that referenced
this pull request
Feb 26, 2025
web-padawan
added a commit
that referenced
this pull request
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix for a problem found in #8702 (comment)
The original logic added in #7609 didn't take into account cases where
popover.targetisn't focused, but wraps a focusable element instead asfocusElement, which is the case for text-field and other field components.Modified original tests to run also with
focusElementcase (it's better to review with "ignore whitespace changes").Type of change