feat: add ariaTarget property for setting aria-describedby #6320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web-padawan
force-pushed
the
feat/tooltip-aria-target
branch
from
9a13a80 to
c995fd5
Compare
sissbruecker
reviewed
Aug 8, 2023
sissbruecker
approved these changes
Aug 8, 2023
Co-authored-by: Sascha Ißbrücker <sissbruecker@vaadin.com>
|
Kudos, SonarCloud Quality Gate passed!
|
|
This ticket/PR has been released with Vaadin 24.2.0.alpha7 and is also targeting the upcoming stable 24.2.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related to #6287
In case of input field components, we want the tooltip to be shown on top of the element including label, so
targetis set to thevaadin-text-fielditself. However,aria-describedbyelement needs to be set on the<input>element itself.This PR adds missing API to allow configuring where to set
aria-describedbyattribute.Type of change
Note
We could just check if the component has its own
ariaTarget(the one that comes fromFieldMixin) and use that to set the attribute. This would allow us to avoid adding new API at this point. However, that solution doesn't sound nice to me as it makesvaadin-tooltipcoupled with the underlying implementation details of field components.