-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add clang runtime feature #579
Conversation
This reverts commit 159ac0b.
std = [] | ||
export-src = ["std"] | ||
clang-runtime = ["clang/runtime"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[features] とは,
featureはcrateが提供するビルドフラグ
std feature, export-src fatureがすでに入っている,という状況.
たとえば,
https://github.com/ut-issl/c2a-core/pull/568/files
は export-src
を指定したときだけ,source_dir() がつかえる.指定するのは,crateを使う側(c2a-coreは crate 側).
crateを使う側が使えるfeatureを列挙してるのがfeatures
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
default はcrate利用者側が明示的に指定しなくてもあたるfeature
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hoge = [fuga} は,hoge featureを使うときに,fuga featureを指定して使う,ということ
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-runtime = ["clang/runtime"]
は,clang crateにruntime featureを指定していることができるfeatureである clang-runtime feature を追加してる.(それをc2a core crate利用者が使えるようにしてる)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
export-src = ["std"]
は,export-src feature が c2a core が提供しており,これを指定するとstd featureも勝手に有効にある.
概要
clang
crate(正確にはその dependency のclang-sys
crate)のruntime
feature を使って libclang をリンクする詳細
clang-runtime
feature を追加clang
crate にruntime
feature を指定clang-runtime
を default feature にした検証結果
test へのリンクや,検証結果へのリンク
影響範囲
CI や
c2a-core
crate のユーザがlibclang
のリンクのことを考えなくてよくなる備考
一連のPRマージ後にPre Release したい