Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clang runtime feature #579

Merged
merged 3 commits into from
May 23, 2023
Merged

Add clang runtime feature #579

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9cb976d
add clang-runtime feature for fix link problem
sksat May 17, 2023
e7c79fb
change clang-runtime feature to default feature
sksat May 17, 2023
b5cbc86
Revert "install libclang-dev in Rust CI"
sksat May 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions .github/workflows/rust.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,6 @@ jobs:
steps:
- uses: actions/checkout@v3

- name: install dependencies
run: |
sudo apt-get update -y
sudo apt-get install -y libclang-dev

- uses: dtolnay/rust-toolchain@v1
with:
toolchain: stable
Expand Down
2 changes: 2 additions & 0 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,10 @@ repository = "https://github.com/ut-issl/c2a-core"
documentation = "https://ut-issl.github.io/c2a-reference/c2a-core"

[features]
default = ["clang-runtime"]
std = []
export-src = ["std"]
clang-runtime = ["clang/runtime"]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[features] とは，
featureはcrateが提供するビルドフラグ

std feature, export-src fatureがすでに入っている，という状況．

たとえば，

https://github.com/ut-issl/c2a-core/pull/568/files

は export-src を指定したときだけ，source_dir() がつかえる．指定するのは，crateを使う側（c2a-coreは crate 側）．

crateを使う側が使えるfeatureを列挙してるのがfeatures

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

default はcrate利用者側が明示的に指定しなくてもあたるfeature

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hoge = [fuga} は，hoge featureを使うときに，fuga featureを指定して使う，ということ

Copy link
Collaborator

@meltingrabbit meltingrabbit May 23, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-runtime = ["clang/runtime"]

は，clang crateにruntime featureを指定していることができるfeatureである clang-runtime feature を追加してる．（それをc2a core crate利用者が使えるようにしてる）

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

export-src = ["std"]

は，export-src feature が c2a core が提供しており，これを指定するとstd featureも勝手に有効にある．


[build-dependencies]
semver = "1.0.17"
Expand Down