Move the styles.css sourcemap from inline to an external file #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
dmethvin-gov
force-pushed
the
120-sourcemap
branch
from
d86cebd
to
cfb79a5
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like the embedded map was introduced in c889c5c, postcss generates an embedded map by default whereas node-sass does not generate a map at all unless provoked to do so. My solution here is to generate a map in both steps but make it an external map.
The map references the locations of the original source scss files; postcss does not seem to have the option to include original source, plus it's actually processing the combined css file that node-sass has already digested. With that in mind, I'm not sure how useful this map actually will be in debugging but we can determine that later. On the bright side, the css file is now 400KB lighter which was the original complaint of #120.