Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TRB 2024 OpenScenario left turn scenario #180

Closed
wants to merge 2 commits into from
Closed

Conversation

adamlm
Copy link
Contributor

@adamlm adamlm commented Nov 29, 2023

PR Details

Description

This PR adds the left-turn scenario for TRB.

Related GitHub Issue

Closes #179

Related Jira Key

Progresses CDAR-399
Closes CDAR-518

Motivation and Context

We want to persist the TRB 2024 scenario configuration so it can be easily used by others.

How Has This Been Tested?

Manually tested in simulation

Types of changes

  • New feature (non-breaking change that adds functionality)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • All new and existing tests passed.

@adamlm adamlm requested a review from MishkaMN November 29, 2023 14:18
@MishkaMN
Copy link
Contributor

This has a lot of extra changes it looks like. I am assuming this was for dummy testing for mosaic?

@adamlm
Copy link
Contributor Author

adamlm commented Nov 30, 2023

This has a lot of extra changes it looks like. I am assuming this was for dummy testing for mosaic?

Yes, I was trying to inject detected object data directly into MOSAIC, but the ambassador didn't work. I will remove those changes so the PR affects only ScenarioRunner.

@MishkaMN MishkaMN marked this pull request as ready for review December 20, 2023 17:13
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@MishkaMN
Copy link
Contributor

Closing in favor of #187

@MishkaMN MishkaMN closed this Dec 20, 2023
@MishkaMN MishkaMN deleted the 179-trb-2024 branch December 20, 2023 17:39
MishkaMN added a commit that referenced this pull request Dec 20, 2023
# PR Details
## Description

This PR adds the left-turn scenario for TRB.
Replaces this PR: #180
## Related GitHub Issue

Closes #179 

## Related Jira Key

Progresses [CDAR-399](https://usdot-carma.atlassian.net/browse/CDAR-399)
Closes [CDAR-518](https://usdot-carma.atlassian.net/browse/CDAR-518)

## Motivation and Context

We want to persist the TRB 2024 scenario configuration so it can be
easily used by others.

## How Has This Been Tested?

Manually tested in simulation

## Types of changes

- [x] New feature (non-breaking change that adds functionality)

## Checklist:

- [x] My change requires a change to the documentation.
- [ ] I have updated the documentation accordingly.
- [x] I have read the
[**CONTRIBUTING**](https://github.com/usdot-fhwa-stol/carma-platform/blob/develop/Contributing.md)
document.
- [x] All new and existing tests passed.


[CDAR-399]:
https://usdot-carma.atlassian.net/browse/CDAR-399?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ

[CDAR-518]:
https://usdot-carma.atlassian.net/browse/CDAR-518?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add TRB scenario
2 participants