Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/vru two heavy vehicles #172

Merged
merged 4 commits into from
Nov 9, 2023
Merged

Conversation

EricChen-Lei
Copy link
Contributor

@EricChen-Lei EricChen-Lei commented Nov 8, 2023

PR Details

Description

add 3 trucks for VRU scenario

Related GitHub Issue

Related Jira Key

CDAR-432

Motivation and Context

How Has This Been Tested?

Types of changes

  • Defect fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that cause existing functionality to change)

Checklist:

  • I have added any new packages to the sonar-scanner.properties file
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@EricChen-Lei EricChen-Lei requested review from chengyuan0124, MishkaMN and paulbourelly999 and removed request for paulbourelly999 November 8, 2023 17:04
MishkaMN
MishkaMN previously approved these changes Nov 8, 2023
Comment on lines +1 to +9
<?xml version="1.0" encoding="UTF-8"?>

<!-- generated on 2023-11-06 15:52:06 by Eclipse SUMO netedit Version 1.18.0
-->

<additional xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="http://sumo.dlr.de/xsd/additional_file.xsd">
<!-- StoppingPlaces -->
<busStop id="bs_2" lane="10_3" startPos="2.00" endPos="8.00"/>
</additional>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we are not using bus stop, do we still need this? or is also being used for the heavy_vehicles to stop?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's actually used in the rou.xml file, under the third car

<stop busStop="bs_2" duration="5.00"/>
</vehicle>
<vehicle id="v_3" type="vehicle.carlamotors.carlacola" depart="999.00" route="r_0"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this one? seems like there are 4 vehicles?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is used for keeping the scenario alive, if we only have three cars, the simulation will stop after the last car finishes, might not give us time for other Carma stuff we want to do, this is a safety

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add some sort of comment indicating that this vehicle is just there to extend the CARLA scenario.

Copy link

sonarqubecloud bot commented Nov 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.21) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@MishkaMN MishkaMN merged commit 32d0272 into develop Nov 9, 2023
5 of 6 checks passed
@adamlm adamlm deleted the feature/VRU_two_heavy_vehicles branch November 29, 2023 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants