Move CodePointTrie to components/utils #1114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
echeran
commented
Sep 28, 2021
| pub struct CodePointTrie<'trie, W: ValueWidth, T: TrieType> { | ||
| #[cfg_attr(feature = "serde", derive(Serialize, Deserialize))] | ||
| pub struct CodePointTrie<'trie, W: ValueWidth> | ||
| where <<W as AsULE>::ULE as ULE>::Error: Display |
There was a problem hiding this comment.
One of the compiler errors was that, as I understood it, the default implementation of Serde provided by the derive required that the Error type implement std::fmt::Display, but instead, the added trait bound uses core::fmt::Display. Is that ok?
There was a problem hiding this comment.
We should avoid putting trait bounds on the struct. Trait bounds belong on impls. Serde complaining isn't a good reason to put a trait bound on a struct. Manish shared a really good article on the subject last week: https://stackoverflow.com/questions/49229332/should-trait-bounds-be-duplicated-in-struct-and-impl/66369912#66369912
sffc
requested changes
Oct 1, 2021
|
CC @Manishearth who may want to review this |
Manishearth
approved these changes
Oct 1, 2021
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1070
Done so far in this PR: