Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CodePointTrie - polish and move to utils #1070

Closed
3 tasks done
Tracked by #148
echeran opened this issue Sep 20, 2021 · 1 comment · Fixed by #1114
Closed
3 tasks done
Tracked by #148

CodePointTrie - polish and move to utils #1070

echeran opened this issue Sep 20, 2021 · 1 comment · Fixed by #1114
Assignees
@echeran
Labels
C-unicode Component: Props, sets, tries S-medium Size: Less than a week (larger bug fix or enhancement) T-core Type: Required functionality
Milestone
2021 Q3 0.4 Sprint C

Comments

@echeran
Copy link
Contributor

echeran commented Sep 20, 2021 •
edited
Loading

  • Write Serde impl
  • Remove second type param
  • Audit documentation
@echeran echeran added T-core Type: Required functionality C-unicode Component: Props, sets, tries S-medium Size: Less than a week (larger bug fix or enhancement) labels Sep 20, 2021
@echeran echeran mentioned this issue Sep 20, 2021
Closed
@sffc sffc mentioned this issue Sep 21, 2021
Closed
6 tasks
@echeran echeran self-assigned this Sep 21, 2021
@echeran echeran added this to the 2021 Q3 0.4 Sprint C milestone Sep 21, 2021
@sffc sffc changed the title CodePointTrie - write Serde impl and remove second type param CodePointTrie - polish and move to utils Sep 25, 2021
@sffc
Copy link
Member

sffc commented Sep 25, 2021

@echeran I updated this issue slightly to be about graduating CodePointTrie from experimental. In addition to Serde and the type parameter, we should also audit the documentation.

@echeran echeran mentioned this issue Sep 27, 2021
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@echeran echeran

Labels
C-unicode Component: Props, sets, tries S-medium Size: Less than a week (larger bug fix or enhancement) T-core Type: Required functionality
Projects
None yet
Milestone
2021 Q3 0.4 Sprint C
Development

Successfully merging a pull request may close this issue.

Move CodePointTrie to components/utils echeran/icu4x
2 participants
@echeran @sffc