Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crate layout of Unicode Properties #1136

Closed
3 tasks done
sffc opened this issue Oct 1, 2021 · 3 comments · Fixed by #1153 or #1191
Closed
3 tasks done

Crate layout of Unicode Properties #1136

sffc opened this issue Oct 1, 2021 · 3 comments · Fixed by #1153 or #1191
Assignees
@echeran
Labels
C-unicode Component: Props, sets, tries S-tiny Size: Less than an hour (trivial fixes) T-core Type: Required functionality
Milestone
ICU4X 0.4

Comments

@sffc
Copy link
Member

sffc commented Oct 1, 2021 •
edited
Loading

As of #1114, we have:

  • UnicodeSet in components/uniset
  • Unicode properties in components/uniset/src/props.rs
  • CodePointTrie in utils/codepointtrie

I think we should move components/uniset to utils/uniset, but we should keep the properties stuff in a new crate such as components/properties or components/uprops.

Thoughts? Approval?
@sffc sffc added T-core Type: Required functionality C-unicode Component: Props, sets, tries S-tiny Size: Less than an hour (trivial fixes) needs-approval One or more stakeholders need to approve proposal labels Oct 1, 2021
@iainireland
Copy link
Contributor

Yeah, I've been thinking we should do something along these lines for a while.

@zbraniecki
Copy link
Member

I like components/properties

@echeran
Copy link
Contributor

echeran commented Oct 18, 2021

Is a/the guiding principle here that utils includes data structures like FixedDecimal, CodePointTrie, UnicodeSet, and the user-facing APIs live in components? If so, everything above makes sense.

@echeran echeran linked a pull request Oct 18, 2021 that will close this issue
Refactor properties to separate crate #1153
Merged
@sffc sffc added this to the ICU4X 0.4 milestone Oct 18, 2021
@echeran echeran linked a pull request Oct 19, 2021 that will close this issue
Refactor historical perf benchmark data to match uniset source code dir move #1191
Merged
@sffc sffc removed the needs-approval One or more stakeholders need to approve proposal label Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@echeran echeran

Labels
C-unicode Component: Props, sets, tries S-tiny Size: Less than an hour (trivial fixes) T-core Type: Required functionality
Projects
None yet
Milestone
ICU4X 0.4
4 participants
@zbraniecki @echeran @sffc @iainireland