Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: slither errors #681

Merged
merged 15 commits into from Jun 26, 2023
Merged

fix: slither errors #681

merged 15 commits into from Jun 26, 2023

Conversation

ghost
Copy link

@ghost ghost commented Jun 15, 2023

Resolves #536

this pull request is to resolve the slither errors which was coming from
yarn workspace @ubiquity/contracts run test:slither

@ghost ghost requested a review from zgorizzo69 as a code owner June 15, 2023 12:26
@ubiquibot
Copy link

ubiquibot bot commented Jun 15, 2023 •
edited
Loading

Deployment: Thu Jun 15 2023 12:32:38 (UTC)
Deployment: Thu Jun 15 2023 20:23:41 (UTC)
Deployment: Sun Jun 18 2023 19:13:36 (UTC)
Deployment: Mon Jun 19 2023 08:39:06 (UTC)
Deployment: Mon Jun 19 2023 09:10:20 (UTC)
Deployment: Mon Jun 19 2023 11:01:57 (UTC)
Deployment: Mon Jun 19 2023 11:32:44 (UTC)
Deployment: Mon Jun 19 2023 11:48:48 (UTC)
Deployment: Mon Jun 19 2023 13:50:17 (UTC)
Deployment: Tue Jun 20 2023 10:01:31 (UTC)
Deployment: Tue Jun 20 2023 11:07:46 (UTC)
Deployment: Thu Jun 22 2023 08:09:22 (UTC)
Deployment: Sun Jun 25 2023 16:44:29 (UTC)

@ghost
Copy link
Author

ghost commented Jun 15, 2023

@rndquu hm all the checks passed

@rndquu
Copy link
Member

rndquu commented Jun 15, 2023

@rndquu hm all the checks passed

@AnakinSkywalkeer could you reenable the slither ci workflow (i.e. add "pull_request" and "push" handlers) so that we could check how it works

@ghost
Copy link
Author

ghost commented Jun 15, 2023

@rndquu hm all the checks passed

@AnakinSkywalkeer could you reenable the slither ci workflow (i.e. add "pull_request" and "push" handlers) so that we could check how it works

sure

@ghost
Copy link
Author

ghost commented Jun 15, 2023

@rndquu hm all the checks passed

@AnakinSkywalkeer could you reenable the slither ci workflow (i.e. add "pull_request" and "push" handlers) so that we could check how it works

um ah i didn't get how to enable it hm 🤔

@ghost
Copy link
Author

ghost commented Jun 15, 2023

isn't enabling workflow requires admin perms

@ghost ghost requested a review from 0x4007 June 15, 2023 19:40
@ghost
Copy link
Author

ghost commented Jun 15, 2023

@pavlovcik i added the collectable dust files back it seems to passed the tests too

@0x4007
Copy link
Member

0x4007 commented Jun 15, 2023 •
edited
Loading

I added comments where I think I can add value. The Slither stuff is a bit out of my wheelhouse, perhaps I can get another approval in here.

@0x4007 0x4007 requested a review from rndquu June 15, 2023 20:39
@ghost
Copy link
Author

ghost commented Jun 16, 2023

@rndquu can u take a look pls

0x4007
0x4007 approved these changes Jun 18, 2023
View reviewed changes
Copy link
Member

@0x4007 0x4007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me but I'm not a Solidity developer.

@ghost ghost mentioned this pull request Jun 18, 2023
Closed
rndquu
rndquu requested changes Jun 19, 2023
View reviewed changes
Copy link
Member

@rndquu rndquu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. The slither CI workflow still fails, pls fix
  2. Pls enable the slither CI workflow to be executed on push and pull_request

packages/contracts/slither.config.json Outdated Show resolved Hide resolved
packages/contracts/src/dollar/core/ERC1155Ubiquity.sol Outdated Show resolved Hide resolved
packages/contracts/src/dollar/core/ERC1155Ubiquity.sol Outdated Show resolved Hide resolved
packages/contracts/src/dollar/core/ERC1155Ubiquity.sol Outdated Show resolved Hide resolved
@ghost
Copy link
Author

ghost commented Jun 19, 2023

@rndquu enabled the slither analysis

@rndquu rndquu marked this pull request as draft June 19, 2023 10:02
@ghost
Copy link
Author

ghost commented Jun 20, 2023

@rndquu slither is not running can u take a look?

@ghost
Copy link
Author

ghost commented Jun 20, 2023

okay its working now seems like it was problem on the github side

@ghost ghost requested a review from rndquu June 20, 2023 11:23
@rndquu
Copy link
Member

rndquu commented Jun 20, 2023

@zgorizzo69 pls check this PR

@ghost ghost mentioned this pull request Jun 20, 2023
Closed
@rndquu
Copy link
Member

rndquu commented Jun 22, 2023

@AnakinSkywalkeer could you resolve conflicts?

@ghost
Copy link
Author

ghost commented Jun 22, 2023

@AnakinSkywalkeer could you resolve conflicts?

there was seems to be due to yarn.lock i did the change lets see if it gets fixed

@ghost
Copy link
Author

ghost commented Jun 22, 2023

its failing let me fix

@ghost
Copy link
Author

ghost commented Jun 22, 2023

@rndquu i fixed it

@rndquu rndquu self-requested a review June 23, 2023 06:45
@ghost ghost mentioned this pull request Jun 23, 2023
Closed
@0x4007
Copy link
Member

0x4007 commented Jun 24, 2023 •
edited
Loading

I still see warnings. Also shouldn't it be installing Solidity 0.8.19?

https://github.com/ubiquity/ubiquity-dollar/actions/runs/5343061138/jobs/9685652437

I just reviewed the bounty so we can handle warnings another time.

@ghost
Copy link
Author

ghost commented Jun 24, 2023

I still see warnings. Also shouldn't it be installing Solidity 0.8.19?

https://github.com/ubiquity/ubiquity-dollar/actions/runs/5343061138/jobs/9685652437

I just reviewed the bounty so we can handle warnings another time.

oh yes the solc version is set to 0.8.16 hm should i change it?

image

@0x4007
Copy link
Member

0x4007 commented Jun 24, 2023

I think it makes sense to match our smart contracts but I will delegate the decision to my colleagues.

@rndquu
Copy link
Member

rndquu commented Jun 25, 2023

We don't really need solc-select because foundry is able to download the required solc compiler version itself and slither simply doesn't need one because it is a static analyzer

@AnakinSkywalkeer Could you remove these steps (one and two) and update the PR?

@ghost
Copy link
Author

ghost commented Jun 25, 2023

We don't really need solc-select because foundry is able to download the required solc compiler version itself and slither simply doesn't need one because it is a static analyzer

@AnakinSkywalkeer Could you remove these steps (one and two) and update the PR?

Sure

@ghost
Copy link
Author

ghost commented Jun 25, 2023

@rndquu did it

@0x4007
Copy link
Member

0x4007 commented Jun 25, 2023

Unless we need zgo input, please feel free to merge @rndquu

@rndquu
Copy link
Member

rndquu commented Jun 26, 2023

Unless we need zgo input, please feel free to merge @rndquu

let's wait for @zgorizzo69 's review

@zgorizzo69
Copy link
Contributor

lgtm ! good job

@zgorizzo69 zgorizzo69 merged commit 2a330ba into ubiquity:development Jun 26, 2023
@0x4007
Copy link
Member

0x4007 commented Jun 26, 2023 •
edited
Loading

Oddly enough CI fails on development now, even though the latest commit passed.

https://github.com/ubiquity/ubiquity-dollar/actions/runs/5382075058/jobs/9766993102

@ghost
Copy link
Author

ghost commented Jun 26, 2023 •
edited by ghost
Loading

Oddly enough CI fails on development now, even though the latest commit passed.

https://github.com/ubiquity/ubiquity-dollar/actions/runs/5382075058/jobs/9766993102

thats kinda weird

@ghost
Copy link
Author

ghost commented Jun 27, 2023

Running slither tests locally are passing without any errors 🤔
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zgorizzo69 zgorizzo69 Awaiting requested review from zgorizzo69

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix slither CI errors - II
3 participants
@rndquu @0x4007 @zgorizzo69