prettier in package.json calling forge fmt

[0x4007]

I just realized that this could be causing the discrepancy with the formatting. Because this task is named "prettier" it is possible that lint-staged is calling this instead of what we expect.

Originally posted by @pavlovcik in #417 (comment)

---

 "devDependencies": {
    "cspell": "latest",
    "prettier": "latest",
    "prettier-plugin-solidity": "latest"
  }

if we agree to keep prettier over forge fmt we need to :
1 - add the dev dependencies as stated above
2 - update the overrides section of the .prettierrc in the root folder

Originally posted by @zgorizzo69 in #417 (comment)

[0x4007]

@zgorizzo69 can you clarify what exactly you think I should do for

update the overrides section of the .prettierrc in the root folder

I basically already handled this in my mega PR. Here's the commit with the latest change https://github.com/ubiquity/ubiquity-dollar/blob/91db6ed9376c7fe1480a9b063e44c94d61a583ac/packages/contracts/package.json

[FibrinLab]

I think this is causing the formatting errors for the solidity files.

@pavlovcik

[FibrinLab]

@pavlovcik Currently working on issue

I think this is causing the formatting errors for the solidity files.
@pavlovcik

Maybe try just using tab_width = 4 with the formatter. I believe it defaults to 2

[0x4007]

@pavlovcik Currently working on issue

This is assigned to me so don't worry about it.

@FibrinLab we will not use forge fmt. We will only use prettier so I'm planning to just delete that config.

[ghost]

/start

[ubiquibot]

Skipping /start since the issue is closed

[molecula451]

/start

[ubiquibot]

Skipping /start since the issue is closed

[molecula451]

mind unassing if not working on the issue?

[0x4007]

mind unassing if not working on the issue?

If you can follow up in a couple of days and there are no updates then we can assign you!

[molecula451]

mind unassing if not working on the issue?

If you can follow up in a couple of days and there are no updates then we can assign you!

I just follow up, it looks like assignee it's not working on it after all

#685

[ghost]

imma make a PR soon

[ghost]

I just realized that this could be causing the discrepancy with the formatting. Because this task is named "prettier" it is possible that lint-staged is calling this instead of what we expect.

Originally posted by @pavlovcik in #417 (comment)

 "devDependencies": {
    "cspell": "latest",
    "prettier": "latest",
    "prettier-plugin-solidity": "latest"
  }

if we agree to keep prettier over forge fmt we need to : 1 - add the dev dependencies as stated above 2 - update the overrides section of the .prettierrc in the root folder

Originally posted by @zgorizzo69 in #417 (comment)

hey,
can u tell which thing in override i gotta change
on reading the above talk i see we gotta put tab width 4 which it is already

    {
      "files": "*.sol",
      "options": {
        "printWidth": 80,
        "tabWidth": 4,
        "useTabs": false,
        "singleQuote": false,
        "bracketSpacing": false
      }
    }
  ]

[ghost]

@pavlovcik im gonna push the changes to #681

[rndquu]

@pavlovcik im gonna push the changes to #681

Pls create a separate PR, no need to clutter #681

[ghost]

@pavlovcik im gonna push the changes to #681

Pls create a separate PR, no need to clutter #681

oh sure i reverted the PR gonna make a separate

[ghost]

/unassign

[ubiquibot]

You have been unassigned from the bounty @AnakinSkywalkeer

[ubiquibot]

@molecula451 The time limit for this bounty is on Tue, 20 Jun 2023 15:58:51 GMT

[molecula451]

@molecula451 The time limit for this bounty is on Tue, 20 Jun 2023 15:58:51 GMT

#685

[ubiquibot]

[ CLAIM 200 WXDAI ]

0x4D0704f4...D826dCFc4