Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge 8.5 changes into GroupBy feature branch #1055

Merged
merged 20 commits into from
Sep 19, 2019

Commits on Sep 9, 2019

  1. Configuration menu
    Copy the full SHA
    26c3828 View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2019

  1. Configuration menu
    Copy the full SHA
    1ef1ffa View commit details
    Browse the repository at this point in the history
  2. update roadmap url (ubccr#1031)

    update roadmap url and reenable tests
    plessbd authored Sep 10, 2019
    Configuration menu
    Copy the full SHA
    5dc3d39 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    401283e View commit details
    Browse the repository at this point in the history
  4. Refresh clears the search field

    mkzia committed Sep 10, 2019
    Configuration menu
    Copy the full SHA
    c1c2cf5 View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2019

  1. Merge pull request ubccr#1028 from mkzia/bug_fixes2

    Bug fixes: Add mask and make chart name unique
    mkzia authored Sep 11, 2019
    Configuration menu
    Copy the full SHA
    891566d View commit details
    Browse the repository at this point in the history
  2. Add help window for Dashboard Components

    A dashboard component author should add a 'help' property that contains
    the definition of the help window title and contents.
    
    Also update all components to inherit from the appropriate base
    class.
    jpwhite4 committed Sep 11, 2019
    Configuration menu
    Copy the full SHA
    c8afc9e View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2019

  1. Merge pull request ubccr#1036 from jpwhite4/helpwin

    Add help window for Dashboard Components
    jpwhite4 authored Sep 12, 2019
    Configuration menu
    Copy the full SHA
    dd3ffc6 View commit details
    Browse the repository at this point in the history
  2. Update profile editor for renamed rest interface.

    Also change the conditional statement to be more obvious as to its
    purpose.
    jpwhite4 committed Sep 12, 2019
    Configuration menu
    Copy the full SHA
    940735b View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2019

  1. Configuration menu
    Copy the full SHA
    59e8de6 View commit details
    Browse the repository at this point in the history
  2. Merge pull request ubccr#1038 from jpwhite4/reset_dashboard_layout

    Update profile editor for renamed rest interface.
    jpwhite4 authored Sep 13, 2019
    Configuration menu
    Copy the full SHA
    1bfcb33 View commit details
    Browse the repository at this point in the history
  3. Merge pull request ubccr#1042 from jpwhite4/default_charts

    Update dashboard chart display algorithm
    jpwhite4 authored Sep 13, 2019
    Configuration menu
    Copy the full SHA
    7c07a65 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2019

  1. Add help images for core dashboard components (ubccr#1044)

    * Add help images for core dashboard components
    jpwhite4 authored and plessbd committed Sep 17, 2019
    Configuration menu
    Copy the full SHA
    f4628ae View commit details
    Browse the repository at this point in the history
  2. Minor text changes (ubccr#1045)

    mkzia authored and plessbd committed Sep 17, 2019
    Configuration menu
    Copy the full SHA
    446d371 View commit details
    Browse the repository at this point in the history
  3. Fix metric explorer metric and dimension display bug.

    The metric explorer uses a renderer to convert the internal ids to
    the human readable values for many of the combo boxes. The lookup
    function was incorrectly using the store.find() call which only
    performs a substring match. In the observed case the defined metrics
    were:
    
    job_count_bad => 'Number of Inefficient Jobs'
    job_count   => 'Number of Jobs'
    
    so when the code looked up the text for the job_count metric
    the find() function would match the job_count_bad string
    and the wrong text would be displayed.
    
    This bug has been in the system forever. Why have we not noticed
    it before. Well the backend code sorts the data
    so that the human readable strings appear in alphabetical order. So
    for example the resource / resource_type group by ends up sorted in the
    following order:
    
    resource => 'Resource'
    resource_type => 'Resource Type'
    
    therefore resource appears in the list first and a substring lookup
    for resource returns the expected value. So, by luck most of the
    cases do not happen. The only one I found is the SUPREMM Requested Wall
    Hours Per Job and Requested Wall Hours: Total.
    
    An even more curious reader might ask why updates to the JobEfficiency
    realm would impact the job data. Well the code in the metric explorer
    ignores the realm when building the list of statistics. So if two
    different realms have the same metric then the text description for the
    first one wins. In this case JobEfficiency is before Jobs in the
    alphabet.
    jpwhite4 committed Sep 17, 2019
    Configuration menu
    Copy the full SHA
    6810bdf View commit details
    Browse the repository at this point in the history
  4. Merge pull request ubccr#1046 from jpwhite4/metric_display

    Fix metric explorer metric and dimension display bug.
    jpwhite4 authored Sep 17, 2019
    Configuration menu
    Copy the full SHA
    ed6dcf9 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    078f3e1 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2019

  1. Fix Usage UI Regression (ubccr#1053)

    * Fix Usage UI Regression
    
    - Fixed std-error checkbox being enabled vs. disabled for statistics.
    - Fixed chart exception handling to work when the response does not contain
      json. Uses the standard `presentFailure` function instead of a message box.
    - Also updated the `presentFailure` function so that the wrapped message is
      displayed on the next line.
    
    Co-Authored-By:Benjamin D. Plessinger <ben@plessinger.us>
    ryanrath authored Sep 19, 2019
    Configuration menu
    Copy the full SHA
    cf85af6 View commit details
    Browse the repository at this point in the history
  2. Merge pull request ubccr#1047 from jpwhite4/show_in_catalog

    Add ability to hide realm from the metric catalog
    jpwhite4 authored Sep 19, 2019
    Configuration menu
    Copy the full SHA
    908511d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    7121937 View commit details
    Browse the repository at this point in the history