Merge 8.5 changes into GroupBy feature branch #1055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update roadmap url and reenable tests
Bug fixes: Add mask and make chart name unique
A dashboard component author should add a 'help' property that contains the definition of the help window title and contents. Also update all components to inherit from the appropriate base class.
Add help window for Dashboard Components
Also change the conditional statement to be more obvious as to its purpose.
Update profile editor for renamed rest interface.
Update dashboard chart display algorithm
* Add help images for core dashboard components
The metric explorer uses a renderer to convert the internal ids to the human readable values for many of the combo boxes. The lookup function was incorrectly using the store.find() call which only performs a substring match. In the observed case the defined metrics were: job_count_bad => 'Number of Inefficient Jobs' job_count => 'Number of Jobs' so when the code looked up the text for the job_count metric the find() function would match the job_count_bad string and the wrong text would be displayed. This bug has been in the system forever. Why have we not noticed it before. Well the backend code sorts the data so that the human readable strings appear in alphabetical order. So for example the resource / resource_type group by ends up sorted in the following order: resource => 'Resource' resource_type => 'Resource Type' therefore resource appears in the list first and a substring lookup for resource returns the expected value. So, by luck most of the cases do not happen. The only one I found is the SUPREMM Requested Wall Hours Per Job and Requested Wall Hours: Total. An even more curious reader might ask why updates to the JobEfficiency realm would impact the job data. Well the code in the metric explorer ignores the realm when building the list of statistics. So if two different realms have the same metric then the text description for the first one wins. In this case JobEfficiency is before Jobs in the alphabet.
Fix metric explorer metric and dimension display bug.
* Fix Usage UI Regression - Fixed std-error checkbox being enabled vs. disabled for statistics. - Fixed chart exception handling to work when the response does not contain json. Uses the standard `presentFailure` function instead of a message box. - Also updated the `presentFailure` function so that the wrapped message is displayed on the next line. Co-Authored-By:Benjamin D. Plessinger <ben@plessinger.us>
Add ability to hide realm from the metric catalog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Merge 8.5 changes into GroupBy feature branch
Motivation and Context
Tests performed
Types of changes
Checklist: