Fix Usage UI Regression #1053
Merged
Fix Usage UI Regression #1053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixed std-error checkbox being enabled vs. disabled for statistics. - Fixed chart exception handling to work when the response does not contain json. Uses the standard `presentFailure` function instead of a message box. - Also updated the `presentFailure` function so that the wrapped message is displayed on the next line. Co-Authored-By:Benjamin D. Plessinger <ben@plessinger.us>
plessbd
approved these changes
Sep 19, 2019
smgallo
added a commit
that referenced
this pull request
Sep 19, 2019
* Add file locking to Data Warehouse Export script (#1029) * Remove data files for deleted export requests (#1030) * update roadmap url (#1031) * Bug fixes: Add mask and make chart name unique * Refresh clears the search field * Add help window for Dashboard Components * Update profile editor for renamed rest interface. * Update dashboard chart display algorithm * Add help images for core dashboard components (#1044) * Add help images for core dashboard components * Minor text changes (#1045) * Fix metric explorer metric and dimension display bug. * Add ability to hide realm from the metric catalog * Fix Usage UI Regression (#1053) * Fix Usage UI Regression Co-Authored-By:Benjamin D. Plessinger <ben@plessinger.us>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
json. Uses the standard
presentFailurefunction instead of a message box.presentFailurefunction so that the wrapped message isdisplayed on the next line.
Motivation and Context
Having a UI that works as expected is good.
Tests performed
Manual testing was performed on local docker instances.
Types of changes
Checklist: