This repository has been archived by the owner on May 4, 2022. It is now read-only.
fix: rm app directory search results count badge, temporarily #843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mitigates bug in which the badge indicates more results than are visible to user, hypothesis: because it's counting items on which user has BROWSE but not SUBSCRIBE whereas actual results listing is only showing items on which user has both. Intended as temporary workaround. Suppresses a misleading badge until can develop a deeper fix to reliably show the correct number in the badge.
apetro
commented
Jul 11, 2018
CHANGELOG.md
Outdated
| @@ -18,6 +18,9 @@ and this project adheres to | |||
|
|
|||
| ### Fixed | |||
|
|
|||
| * Removes app directory search results count badge. Intended as temporary | |||
| mitigation for bug wherein the badge did not reliably show a correct count. | |||
| (#843) | |||
| * Successfully launch searches into today.wisc.edu from Madison's theme (#829) | |||
| * May have fixed a bug where app directory search result badge could get out of | |||
There was a problem hiding this comment.
( #842 would remove this prematurely optimistic changelog entry).
ChristianMurphy
approved these changes
Jul 11, 2018
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mitigates bug in which the badge indicates more results than are visible to user, by removing the unreliable badge.
Intended as temporary workaround. Suppresses a misleading badge until deeper fix to reliably show the correct number in the badge.
Hypothesis: underlying bug is it's including in the badge count items on which user has
BROWSEbut notSUBSCRIBEwhereas the user-visible results listing is only showing items on which user has both kinds of permission.Contributor License Agreement adherence: