This repository has been archived by the owner on May 4, 2022. It is now read-only.
Show app directory search results the user can BROWSE but not SUBSCRIBE #844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They had been counted in search results badge count. Show them last so that badge count and displayed items match and to honor the intention of granting BROWSE without SUBSCRIBE.
This mock app directory entry now serves as an example of an item with canAdd set to false.
Retain launch URL in not-logged-in case since user might be able to log in to gain privileges to really launch the item, and getLaunchURL( app, true) generates a URL suitable for not-logged-in-users to try to log in to gain access.
ChristianMurphy
approved these changes
Jul 13, 2018
|
What are we waiting for on this PR? |
|
We are probably waiting on teeing up local data changes so that the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restores the search result count badge on the app directory results tab. That badge had been temporarily removed in #843 because it was including items the user could BROWSE-but-not-SUBSCRIBE in the count even though those search results were not displayed to the user.
This makes that badge count correct by following through on including the BROWSE-but-not-SUBSCRIBE items in the search results display. These you're-allowed-to-learn-about-this-item-but-you-cannot-actually-launch-it items are displayed at the end of the search results, after the items the user can actually launch.
(The use case here is there may be situations in which it is helpful for a user to know about, reference, show another user about an item in MyUW, even though that item isn't intended for their own use. For instance, academic advisors helping students to understand content available to students, even though the advisors themselves cannot launch all of that content.)
Contributor License Agreement adherence: