Skip to content
This repository has been archived by the owner on May 4, 2022. It is now read-only.

fix: rm app directory search results count badge, temporarily #843

Merged
merged 4 commits into from
Jul 13, 2018
Merged

fix: rm app directory search results count badge, temporarily #843

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ae8d090
fix: rm app directory search results count badge, temporarily
apetro Jul 11, 2018
e07eec6
docs(changelog): note rm app directory search results badge, temporarily
apetro Jul 11, 2018
d5f5155
Merge branch 'master' into suppress-badges
apetro Jul 12, 2018
d8e92b1
Merge branch 'master' into suppress-badges
apetro Jul 13, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,9 @@ and this project adheres to

### Fixed

* Removes app directory search results count badge. Intended as temporary
mitigation for bug wherein the badge did not reliably show a correct count.
(#843)
* Successfully launch searches into today.wisc.edu from Madison's theme (#829)
* May have fixed a bug where app directory search result badge could get out of
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

( #842 would remove this prematurely optimistic changelog entry).

sync with the number of search results actually being displayed. (#827)
Expand Down
2 changes: 1 addition & 1 deletion web/src/main/webapp/my-app/search/partials/search-results.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@
<!-- MyUW RESULTS ONLY -->
<md-tab ng-if="googleSearchEnabled || directoryEnabled">
<md-tab-label>
{{ portal.theme.title }}&nbsp;&nbsp;<span class="badge">{{ appDirectoryResultsBadge }}</span>
{{ portal.theme.title }}
</md-tab-label>
<md-tab-body>
<md-content>
Expand Down