Implement Explanations in RPC #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexjpwalker
approved these changes
Mar 29, 2021
This was referenced Mar 29, 2021
haikalpribadi
requested changes
Mar 30, 2021
added 2 commits
March 30, 2021 14:18
add missing field numbers tmp publish npm, pip, and maven artifacts Move Explanation to //common/logic.proto update answer proto Make map style consistent Revert "Make map style consistent" This reverts commit a625c71. use snake-case split concepts into relation and attributes
final tweaks and publish snapshots undo temporary snapshot publishing
flyingsilverfin
force-pushed
the
explanations-rpc
branch
from
a085965 to
8b5945b
Compare
flyingsilverfin
force-pushed
the
explanations-rpc
branch
from
a712647 to
9a268f7
Compare
haikalpribadi
approved these changes
Mar 30, 2021
flyingsilverfin
added a commit
to typedb/typedb
that referenced
this pull request
Mar 30, 2021
## What is the goal of this PR? To make Explanations and the explain() functionality available to our clients, we implement the protocol extended in typedb/typedb-protocol#131, which creates new RPC endpoints for `QueryManager.explain()` and extended serialisation of `ConceptMap`. ## What are the changes implemented in this PR? * Add RPC endpoint for `QueryManager.explain()` * Extend `ConceptMap` serialisation to serialise `explainableRelations`, `explainableAttributes`, and `explainableOwnerships`
alexjpwalker
pushed a commit
to typedb/typedb-driver-python
that referenced
this pull request
Mar 31, 2021
## What is the goal of this PR? Following typedb/typedb#6271 and the corresponding protocol change in typedb/typedb-protocol#131 we implement Explanations, Explainable concept maps, and the explain() query API, which allows users to stream Explanations on demand **note: explain query or transaction option must be set to `true`** ## What are the changes implemented in this PR? * Implement `Explanation` objects, and extend `ConceptMap` to contain `Explainables` * Add the `QueryManager.explain(Explainable)` API to retrieve all direct explanations (1-rule layer)
alexjpwalker
pushed a commit
to typedb/typedb-driver
that referenced
this pull request
Mar 31, 2021
## What is the goal of this PR? Following typedb/typedb#6271 and the corresponding protocol change in typedb/typedb-protocol#131 we implement Explanations, Explainable concept maps, and the explain() query API, which allows users to stream Explanations on demand **note: explain query or transaction option must be set to `true`** ## What are the changes implemented in this PR? * Implement `Explanation` objects, and extend `ConceptMap` to contain `Explainables` * Add the `QueryManager.explain(Explainable)` API to retrieve all direct explanations (1-rule layer) * update `ClientTest` to include a simple Explanation test
flyingsilverfin
added a commit
to typedb/typedb-driver-nodejs
that referenced
this pull request
Mar 31, 2021
## What is the goal of this PR? We refactor client-nodejs to follow the new architecture set out by client-java in 7963479, and then following typedb/typedb#6271 and the corresponding protocol change in typedb/typedb-protocol#131 we implement Explanations, Explainable concept maps, and the explain() query API, which allows users to stream Explanations on demand **note: `explain` query or transaction option must be set to `true`** ## What are the changes implemented in this PR? * completely overhaul client to match the architecture of client-java * Implement `Explanation` objects, and extend `ConceptMap` to contain `Explainables` * Add the `QueryManager.explain(Explainable)` API to retrieve all direct explanations (1-rule layer)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the goal of this PR?
We add Explanations, and the explain() query endpoint to the protocol. This enables all clients to retrieve all available explanations for a particular explainable concept map.
What are the changes implemented in this PR?
ExplainableandExplainablesas part ofAnswerprotocolExplanationas part ofLogicprotocolExplain.ReqandExplain.Resas part of the explain QueryManager endpoing