-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Explanations #307
Merged
alexjpwalker
merged 16 commits into
typedb:master
from
flyingsilverfin:explanations-rpc
Mar 31, 2021
Merged
Implement Explanations #307
alexjpwalker
merged 16 commits into
typedb:master
from
flyingsilverfin:explanations-rpc
Mar 31, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5d1aa0a
to
945a477
Compare
alexjpwalker
requested changes
Mar 29, 2021
alexjpwalker
approved these changes
Mar 29, 2021
alexjpwalker
approved these changes
Mar 29, 2021
}, WRITE); | ||
|
||
localhostGraknTx(tx -> { | ||
GraqlInsert data = Graql.parseQuery( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is unused, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the goal of this PR?
Following typedb/typedb#6271 and the corresponding protocol change in typedb/typedb-protocol#131 we implement Explanations, Explainable concept maps, and the explain() query API, which allows users to stream Explanations on demand note: explain query or transaction option must be set to
true
What are the changes implemented in this PR?
Explanation
objects, and extendConceptMap
to containExplainables
QueryManager.explain(Explainable)
API to retrieve all direct explanations (1-rule layer)ClientTest
to include a simple Explanation test