This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Implement explanations #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| raise GraknClientException.of(NONEXISTENT_EXPLAINABLE_CONCEPT, variable) | ||
| return explainable | ||
|
|
||
| def ownership(self, owner: str, attribute: str) -> "ConceptMap.Explainable": |
There was a problem hiding this comment.
this typing cracks me up
|
seems good, lets add one basic integration test using explanations, you can use my client-node one as a reference (altho it doesn't pass yet, for some reason we cant get the explainables out again...) |
Done! The integration test passes. |
flyingsilverfin
approved these changes
Mar 31, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the goal of this PR?
Following typedb/typedb#6271 and the corresponding protocol change in typedb/typedb-protocol#131 we implement Explanations, Explainable concept maps, and the explain() query API, which allows users to stream Explanations on demand note: explain query or transaction option must be set to
trueWhat are the changes implemented in this PR?
Explanationobjects, and extendConceptMapto containExplainablesQueryManager.explain(Explainable)API to retrieve all direct explanations (1-rule layer)