JS fixes

[XhmikosR]

This is totally a WIP, but it works for me in both Firefox and Chome without any TypeErrors.

/CC @connor @connors @fat

Any suggestions are welcome.

PS. IE is broken after #446

[XhmikosR]

I've uploaded all my PRs merged changes to http://xhmikosr.github.io/ for testing live with as many browsers as possible.

One thing with the current PR is that I believe we should also set the unprefixed properties. Also, the transition duration doesn't seem to work for Firefox.

Anyway, I'm waiting for feedback in my PRs and let me know if you notice any regressions.

[connors]

Nice. The only thing I still see that doesn't work in Firefox is the Push example.

[XhmikosR]

@connors: that's because that patch is #518 ;)

[connors]

I'm seeing a couple of issues in Chrome and Firefox.

1. The modal example no longer works.
2. The push example has a lot of weirdness when the the user click the back button in the nav-bar.

I say we keep jamming on this for the next release.

[XhmikosR]

This isn't ready... I say it in the OP. Plus I don't really like my approach, but until I have something better I'm keeping this open.

EDIT:

1. the modal example works fine for me in Chrome and Firefox
2. push works fine as long as you move your mouse over after clicking

[XhmikosR]

@hnrch02: any thoughts on this? Seems everyone else isn't available and this patch is very important to ensure everything works on most browsers.

Only thing I don't like is duplicating getBrowserCapabilities but we don't seem to have a common file.

[hnrch02]

Looks fine to me. Some way to share getBrowserCapabilities without duplicating it across files would be nice though, as you mentioned.

[XhmikosR]

The reason I didn't make that separate is I don't know if the new file will be redundant or not...

Otherwise I'll merge this as it is.

[Johann-S]

I think it would be great to have a common.js file because they are few pull requests which need this like :
#675 or #427

[XhmikosR]

How about we just merge this as it is and leave the refactoring for another PR? I'm not sure when I'll have some time to do it myself and it's a pity for Rachet to partially work.

[Johann-S]

Yes i think it would be easy to do it in a separate RP. I'll work on it

[hnrch02]

@XhmikosR Fine by me.

[XhmikosR]

@Johann-S: please CC me if you make a PR to refactor stuff.

[Johann-S]

@XhmikosR yes i want to do that, but i created a PR yesterday (#743) and my PR was closed because a common.js file already existed on this PR : #675

So, i'm not sure if i have to to wait for the merge of this PR (#675) or if i can begin (or continue) my refactoring PR

[XhmikosR]

Personally I believe the refactoring should come first and the other PR
should be rebased after that.
On Feb 4, 2015 10:12 AM, "Johann" notifications@github.com wrote:

@XhmikosR https://github.com/XhmikosR yes i want to do that, but i
created a PR yesterday (#743 #743)
and my PR was closed because a common.js file already existed on this PR :
#675 #675

So, i'm not sure if it's better to wait for the merge of this PR (#675
#675) or if i can begin my
refactoring PR

—
Reply to this email directly or view it on GitHub
#491 (comment).