Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix push.js transition ending listener for Firefox #606

Closed
wants to merge 3 commits into from
Closed

Fix push.js transition ending listener for Firefox #606

wants to merge 3 commits into from

Conversation

pistou
Copy link

@pistou pistou commented Jun 6, 2014

@pistou pistou changed the title Fix transition for Firefox Fix push.js transition for Firefox Jun 7, 2014
@pistou pistou changed the title Fix push.js transition for Firefox Fix push.js transition ending listener for Firefox Jun 7, 2014
@XhmikosR
Copy link
Member

We need to make this a function which will use the right event based on the browser instead of duplicating code.

@XhmikosR
Copy link
Member

Something like I'm trying to do in #491 but I don't like it so much yet thus not merged.

@cvrebert
Copy link
Contributor

It's not clear if Android Firefox is officially supported (see http://goratchet.com/getting-started/). But this is the standard-compliant event name, so adding it seems like a good idea regardless.

@XhmikosR
Copy link
Member

Well, duplicating things like that isn't nice. My solution seems to work, I just need some feedback.

@XhmikosR
Copy link
Member

XhmikosR commented Feb 4, 2015

@Johann-S: can you confirm that this is redundant now in the current master?

@Johann-S
Copy link
Member

Johann-S commented Feb 4, 2015

Yes It's redundant, but i think we will have to fix push.js using getBrowserCapabilities to get
the right prefix and remove or add the right event listener for the right browser.

@XhmikosR
Copy link
Member

XhmikosR commented Feb 4, 2015

Indeed. Can you make a new PR to tackle that please?

@Johann-S
Copy link
Member

Johann-S commented Feb 4, 2015

Yes sure I'll work on it !

But I'll also include my futur new PR to fix push.js when it will be merged on the refactoring (#745) because I'll duplicate code to use getBrowserCapabilities

@XhmikosR
Copy link
Member

XhmikosR commented Feb 4, 2015

OK, closing this then and we'll try to merge #745 first.

@XhmikosR XhmikosR closed this Feb 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants