-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix push.js transition ending listener for Firefox #606
Conversation
Firefox fire the event "transitionend" https://developer.mozilla.org/en-US/docs/Web/Guide/CSS/Using_CSS_transitions#Detecting_the_completion_of_a_transition
We need to make this a function which will use the right event based on the browser instead of duplicating code. |
Something like I'm trying to do in #491 but I don't like it so much yet thus not merged. |
It's not clear if Android Firefox is officially supported (see http://goratchet.com/getting-started/). But this is the standard-compliant event name, so adding it seems like a good idea regardless. |
Well, duplicating things like that isn't nice. My solution seems to work, I just need some feedback. |
@Johann-S: can you confirm that this is redundant now in the current master? |
Yes It's redundant, but i think we will have to fix push.js using |
Indeed. Can you make a new PR to tackle that please? |
Yes sure I'll work on it ! But I'll also include my futur new PR to fix push.js when it will be merged on the refactoring (#745) because I'll duplicate code to use |
OK, closing this then and we'll try to merge #745 first. |
Firefox fire the event "transitionend"
https://developer.mozilla.org/en-US/docs/Web/Guide/CSS/Using_CSS_transitions#Detecting_the_completion_of_a_transition