Fix fingerblaster to use new custom event objects #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You seem to have entered non breaking spaces :P (see Travis build) |
|
BTW @fat is this patch supposed to fix the TypeError in fingerblast? Cause I still get |
|
nah this fixes custom events |
|
👍 some travis issues tho |
|
I went ahead and fixed the Travis build and rebased the PR, feel free to merge it @connors |
connors
added a commit
that referenced
this pull request
Mar 12, 2014
Fix fingerblaster to use new custom event objects
Closed
|
@fat: this breaks IE10 I tried. var e = new MouseEvent(eventName, {
... |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes fingerblast for firefox @connors @connor