小文字への変換ロジックを tr ベースに変更 #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
officel
reviewed
Apr 29, 2024
| @@ -32,7 +32,7 @@ runs: | |||
|
|
|||
| email='' | |||
| name='' | |||
| user=${USER,,} | |||
| user=$(echo $USER | tr [A-Z] [a-z]) | |||
| if [ $user = 'actions-user' ]; then | |||
There was a problem hiding this comment.
input.user が空だった時にこの if 文は [: =: unexpected operator みたいになっちゃう気がする。。。
16行目の user に default で適当な文字列を突っ込む（error的な）とか、
if [ "$user" = 'actions-user' ]; then みたいにしておくとシェルとして安全。というおせっかい。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2 のマージ後、GitHub Actions を実行したところ、macOS で
bad substitutionが発生した。原因はmacOS のBash は3.x で、Bash 4.x から導入された
${USER,,}が使えないため。なので小文字への変換ロジックを
trを使ったものに変更した。参考: https://x.com/raki/status/1784872625019224113