Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

複合アクションからJavaScript アクションへ変更 #6

Merged
merged 10 commits into from
May 11, 2024

Conversation

tshion
Copy link
Owner

@tshion tshion commented May 10, 2024

Bash を使った複合アクションで実装していましたが、下記の理由で比較的慣れているJavaScript ベースに変更したいと思います。

  • Bash のバージョン差異の考慮漏れが多かったため (例: 小文字への変換ロジックを tr ベースに変更 #4 )
  • Bash の " 中にGitHub Actions の式を埋め込んだ際、式の結果に " が入っていると中断されてしまうなど、相性が悪いケースがあり、それを未然に防ぐため
  • 開発する際の環境構築を容易にするため

@tshion tshion self-assigned this May 10, 2024
@tshion tshion changed the title Feature/brush_development 複合アクションからJavaScript アクションへ変更 May 11, 2024
@tshion tshion marked this pull request as ready for review May 11, 2024 04:42
@tshion tshion merged commit 110d2bc into main May 11, 2024
@tshion tshion deleted the feature/brush_development branch May 11, 2024 04:43
tshion added a commit that referenced this pull request May 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant